Add MalformedDllLoading signature for DLL checks#538
Add MalformedDllLoading signature for DLL checks#538kevross33 wants to merge 4 commits intoCAPESandbox:masterfrom
Conversation
Added a new signature class for detecting malformed DLL loading attempts, including checks for hex escapes and API strings in filenames.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the system's malware detection capabilities by adding a new signature specifically designed to identify evasive techniques involving malformed DLL loading. The change allows for the recognition of suspicious patterns in DLL filenames that indicate an attempt to bypass standard analysis, thereby strengthening the overall security posture against sophisticated threats. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Updated description and categories to include anti-sandbox and anti-emulation.
There was a problem hiding this comment.
Code Review
This pull request introduces a new signature, MalformedDllLoading, to detect attempts to load DLLs with malformed names. The implementation is sound and targets specific patterns like excessive hex escapes or the presence of API-like strings in DLL names. My review includes a few suggestions to improve code style, the correctness of the regular expression, and performance by moving a static list to a class attribute. These changes will enhance the readability and efficiency of the new signature.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Added a new signature class for detecting malformed DLL loading attempts, including checks for hex escapes and API strings in filenames.
Aside from cleaning it up I can't take credit as Gemini noticed it on a last past of malicious stuff in Pikabot (SHA256 ca5fb5814ec62c8f04936740aabe2664b3c7d036203afbd8425cd67cf1f4b79d) run and suggested it