Skip to content

Fix dsd threshold behaviour and increase threshold a lil #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
idelder merged 1 commit into from
Aug 11, 2026
Merged

Fix dsd threshold behaviour and increase threshold a lil #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions representative_periods/database_processing_v4_0.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,9 +262,9 @@ def process_single_day_period(database: str, hours: list):

# Get a running proportion sum of DSD
df['run_sum'] = df['dsd'].cumsum()/df['dsd'].sum()
# Get the smallest DSD above thresh to zero out actual table
# Get the largest DSD whose cumulative proportion is still below the threshold
thresh_dsd = df["dsd"].loc[df["run_sum"] < utils.config["dsd_threshold"]].max()
thresh_dsd += 1e-12 # Small buffer to avoid floating point issues
thresh_dsd -= 1e-10 # Small buffer to avoid floating point issues

# There might be nothing under the threshold if using few rep days
if not pd.isna(thresh_dsd) and thresh_dsd < df["dsd"].max():
Expand Down
Loading