Created Cleaner#2
Open
viniFiedler wants to merge 6 commits into
Open
Conversation
- Agora os csv sao armazenados numa pasta e sao limpos de la - O numero de horas que ira ser alocado para cada palestra é dado por uma lista - Todos os csv sao limpos e mergeados em um unico output.csv
[x] cleaner() ordena csvs por nome [x] cleaner() usa informações de lista do config.yaml [x] config.yaml Possui informações do cleaner.py
[x] cleanerCert() ordena csvs por nome [x] cleanerCert() usa informações de lista do config.yaml [x] config.yaml Possui informações do cleaner.py
kszinhu
requested changes
Jun 11, 2022
Member
kszinhu
left a comment
kszinhu
left a comment
There was a problem hiding this comment.
Tudo correto quanto a código mesmo, perfeito.
Correções
- Correção ortográfica
Observações
- Formatação da
PR(Pull Request), ver como se escreve em Markdown (sem muita obrigatoriedade) - Em conjunto com o tópico anterior, vale comentar de
git commit patternse principalmentegit flow
| cleaner_hours: [1, 2] | ||
| ``` | ||
| The input file must contain two columns, 'NAME' and 'HOURS' and be separate by commas. | ||
| The input file must contain two columns, 'NAME' and 'HOURS' and be separate by commas. Or you can use the cleaner by setting it to true ,listing the hours of each event [1,2,3] and then putting all the CSVs in the directory 'inputToClean'. |
Member
There was a problem hiding this comment.
Pequena alteração que remete a ortografia:
Suggested change
| The input file must contain two columns, 'NAME' and 'HOURS' and be separate by commas. Or you can use the cleaner by setting it to true ,listing the hours of each event [1,2,3] and then putting all the CSVs in the directory 'inputToClean'. | |
| The input file must contain two columns, 'NAME' and 'HOURS' and be separate by commas. Or you can use the cleaner by setting it to true, listing the hours of each event [1,2,3] and then putting all the CSVs in the directory 'inputToClean'. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
###Major Changes
-Agora o gerador de certificados possui um
clean.pyque limpa todos os cvs-A funcionalidade é chamada direto na main e pode ser ativida ou desativada pelo
config.yaml-A quantidade de horas que irá ser atribuida a cada evento também é colocada no
config.yaml, no campo cleaner_hours, e precisa ser atribuida em uma lista [ 1, 2, ...] atribuidas em ordem alfabética dos eventos##Minor Changes
readYAML()movida para oclean.py