fix(docs-next): scope basePath to production#114
Merged
pratyush618 merged 1 commit intomasterfrom May 2, 2026
Merged
Conversation
`basePath: '/taskito'` is correct for the deployed GH Pages URL but makes `pnpm dev` 404 at `localhost:3000` because the app moves to `localhost:3000/taskito`. Apply the basePath only when NODE_ENV=production so dev hits the root.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
basePath: '/taskito'was set unconditionally in PR #111 (Phase 1) so the deployed GH Pages site atdocs.byteveda.org/taskitowould resolve correctly. Side effect:pnpm devreturns 404 atlocalhost:3000because the dev server applies the basePath, so the home page lives atlocalhost:3000/taskitoinstead.Wraps
basePathwithprocess.env.NODE_ENV === 'production'so:localhost:3000→ home page (no prefix)/taskitoprefix preserved (GH Pages URL unchanged)Test plan
pnpm build— clean (production build still emits/taskito-prefixed paths)out/index.html— still references/taskito/_next/...chunks correctlypnpm --dir docs-next devand confirmlocalhost:3000andlocalhost:3000/docsboth render