Repository navigation
wesnoth_tactical_ai: let top-level Lua files load - #56
Draft
findalexli wants to merge 1 commit into
Draft
findalexli wants to merge 1 commit into
findalexli wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task finding: #51.
What and why
Every top-level
.luafile fails to load, because the sandbox header ends inif io thenand Wesnoth's Lua raises on an undefined global (variable 'io' must be assigned before being used). The submitted Lua code is never reached and the grade doesn't mention it. The instruction tells solvers to write Lua CAs this way, and local testing, which has no header, loads them.The fix is
if rawget(_G, "io") then, plus the version bump and NOTES.Old vs new
In one raw game each, the three Lua archives logged 150 to 454 lines of load errors and tracebacks on old and none on new. None of the 6 old
judge_output.txtfiles for those archives mentions the error.sforge eval, old then new on the same E2B worker (8 vCPU, 8 GiB), judge keysace23e06dc3band567461e29768.eval_wesnoth.pyis the only judge file that differs. The second starter and example runs are a second pair on a second worker. The real submission ran on its own worker with both images built there, alternating which judge went first. Scores are 0..100, n=2 per side unless stated.The first row's submission has ten top-level
.luafiles. Its config loadsca_recruit.luawithlocation=~add-ons/my_ai/..., and that file requiresmy_ai_loader.luaandwes_ai_lib.lua. On old its load log shows the error and its Lua never runs; on new it loads cleanly and wins 44-47 of 60 games instead of 23-38. The remaining scoring rows are inconclusive at n=2 given Known issue 1.Score effect
.lua: the header is never installed, so the same code runs and scores vary only as in Known issue 1..lua: its code now runs, so its score can move either way. There is no mapping, because the old score never ran it.We found one such submission in public rollouts, and can't say how many others there are. Your archived submissions with a top-level
.luaare the ones to regrade. This change doesn't address Known issue 1.Archives, raw outputs, job scripts and the results scripts: https://github.com/findalexli/EdgeBench/tree/da540564098c8bbc0ad5b9b4cfce0ce53045f8d6/wesnoth_tactical_ai. The Qwen3.8 archive isn't in that folder: it is
export-full47/harness/wesnoth_tactical_ai/final_archive.tar.gzinqwen3.8-flash-next/qwen38fn-full47-part-02.zipof the public rollouts, sha2567af57cb9a751b797d54c8484f0310c72407b4db2432288c73a8891a0b84ab6b1.Checklist for task changes
versionintask.tomlis bumped.NOTES.md: the change and its score effect are under Changes; Source notes the judge change. It isn't a listed Known issue.