Repository navigation
smt_solver: report an evaluator crash as invalid - #45
Draft
findalexli wants to merge 1 commit into
Draft
findalexli wants to merge 1 commit into
findalexli wants to merge 1 commit into
Conversation
This was referenced Nov 4, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task finding: #42. Merge after #43, which removes the crash this finding reports; until then the solver in #42 would go from a valid 0 to invalid.
What and why
When
evaluate.pycrashes,parse_result.pyfinds no score file and reportsvalid: true, score 0, so a judge failure looks like a solver that scored nothing.run.shnow passes on the evaluator's exit status, and no score file with a status other than 0 or 2 givesvalid: false.evaluate.py's "solver is not executable" exit changes from 1 to 2, so a missingsolvestays a valid 0, as today. This looks only at a missing score file, so Known issue 1 stays.Old vs new judge
Old key
cd3a5bf1f538, new3ef6c9298492;sforge eval, one worker, order swapped, n=2 per judge. The new image is the published old tag plus this branch's judge files, because two full builds don't fit a worker's disk.correct=0/0solve, or rejected by preflightcorrect=0/0unknown, or wrong modelscorrect=0/774correct=42/774A valid 0 from a crashed evaluation has no score to map; regrade it. No other score moves.
Checklist for task changes
versionintask.tomlis bumped (any change that can move scores). If smt_solver: validate deep models on a large stack #43 merges first, this becomes 1.2.0.NOTES.md: the change and its score effect are under Changes. No Known issue covered this.