Repository navigation
graph_node_classification: accept prediction keys convertible to strings - #37
Closed
findalexli wants to merge 2 commits into
Closed
findalexli wants to merge 2 commits into
findalexli wants to merge 2 commits into
Conversation
problem.md allows keys convertible to strings, but the verifier looked up only string node IDs, so a complete integer-keyed run matched no node and scored about 0 while marked valid. Convert keys with str() only for a complete answer in which no key matches as given; every other submission is unaffected.
findalexli
added a commit
to findalexli/EdgeBench
that referenced
this pull request
Nov 4, 2026
Contributor
Author
|
Closing for now. Integer keys are allowed and do score about 2, but no real submission we checked uses them (334 public graded entries and 26 fresh solver runs all use string keys). We can reopen if one turns up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task finding: #46.
What and why
problem.mdallows prediction keys "convertible to strings", but the verifier looks up string IDs only, so a complete integer-keyed answer scores about 2 while marked valid. Keys are now converted only when none matches as given, the converted keys are exactly the test nodes, and every value converts withint(). Everything else takes the old path, so string-keyed work scores as before.No natural affected submission is known. The reproducer changes only a real solver's key type, so please decide whether that meets the good-faith criterion. Mixed keys, and integer confidence keys with string prediction keys, stay as they are.
Old vs new judge
tools/judge_local.py, on two workers; old judge built from 1187e2c, whose task files match f92857a. n=4 per judge per row, reversing order, except the half-not-test-nodes row (n=2). Scores out of 100 move only through the solve-time term;overallexcludes it."x"The starter and 103 real string-keyed submission archives, one grade per judge: verdicts unchanged, and quality identical on 102 of 104. The other two varied between grades; both use string keys and bypass the conversion. All rows: long text.
Checklist for task changes
versionintask.tomlis bumped (any change that can move scores).NOTES.md: the change and its score effect are under Changes; no Known issue covered this.