Repository navigation
juliet_vulnerability_analyzer: narrow the "infer" ban to command-like text - #35
Merged
Odysseusqs merged 3 commits intoNov 3, 2026
Merged
Conversation
findalexli
marked this pull request as ready for review
November 2, 2026 07:38
Infer is not in the image and grading is offline, so the command-like pattern enforced little while still flagging harmless text.
Collaborator
|
Thanks for this. We pushed b9125bd to your branch: it drops Old vs new on the same host (
None of the 1185 archived submissions we scanned, from 14 runs, contains the word, so no archived score moves. The tables in this PR's description and in #39 still describe the earlier pattern: the |
Odysseusqs
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Task finding: #39.
score.pysubtracts 100 points if any submitted.pyor.shfile contains the wordinfer, in any case, even in a comment. The README bans calling the Infer tool, but it also says "Infer external inputs". An Opus 5.5 analyzer had this docstring line and scored 0 instead of 79.59:The merged change drops
inferfrom the banned words (b9125bd, from the maintainers). This PR first narrowed the pattern to command-like text. That still flaggedstats["infer"]and missedinfer -j 4 run, and Infer is not in the image and grading is offline. The README's rule against calling it stays, without a text check. Scores can only rise, and only for submissions containing the word.This fixes part of Known issue 3; other banned words in comments still zero a submission (last row).
Checklist for task changes
versionintask.tomlis bumped (any change that can move scores).NOTES.md: the change and its score effect are under Changes; Known issue 3 stays, with its example changed.Old vs new judge
tools/judge_local.py. Old is the judge built from 1187e2c. New is the merged judge, built from f92857a, three grades per row on one worker. Scores had zero spread. The added call lines are never executed; they scored 0 only through the text check.# Infer external inputs from call facts.# we infer the sink from the token facts# infer run lengths from buffer sizessubprocess.run(["infer", "run", "--", "gcc"])subprocess.run(["/opt/infer/bin/infer", "run", "--", "gcc"])scan.shcontaininginfer run -- gcc# does not use CodeQL