Skip to content

fix(ci): opt out of --no-build in org reusable workflow callers#50

Merged
williaby merged 3 commits into
mainfrom
fix/ci-no-build-optouts
Jun 10, 2026
Merged

fix(ci): opt out of --no-build in org reusable workflow callers#50
williaby merged 3 commits into
mainfrom
fix/ci-no-build-optouts

Conversation

@williaby

@williaby williaby commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Summary

The org reusable workflows gained a no-build input defaulting to true, which passes --no-build to uv sync. That fails on this repo's editable hatchling root package:

error: Distribution `python-libs==0.1.0 @ editable+.` can't be installed because it is marked as `--no-build` but has no binary distribution

This is currently breaking the docs, SonarCloud, and FIPS runs on main, and would break the compatibility and mutation runs on their next scheduled trigger.

Changes

Set no-build: false (the reusable workflows' own documented opt-out for hatchling projects) in all five callers:

  • .github/workflows/docs.yml
  • .github/workflows/sonarcloud.yml
  • .github/workflows/fips-compatibility.yml
  • .github/workflows/mutation-testing.yml
  • .github/workflows/python-compatibility.yml

Same fix as applied to sbom.yml within #44 (commit a8e184b).

Verification

Generated with Claude Code

Summary by CodeRabbit

Release Notes

Chores

  • Enhanced CI/CD workflows across documentation generation, FIPS compatibility verification, mutation testing, and code analysis by updating build and package installation configurations in multiple automated testing pipelines.
  • Updated code quality scanning integration by replacing wildcard-based test directory patterns with explicit path configurations for improved reliability and accuracy.
  • Updated code quality service organization identifier.

The org reusable workflows gained a no-build input defaulting to true,
which passes --no-build to uv sync and fails on this repo's editable
hatchling root package (no binary distribution). This broke the docs,
SonarCloud, and FIPS runs on main and would break compatibility and
mutation runs on their next schedule. Set no-build: false in all five
callers, matching the sbom.yml fix merged in #44.
Copilot AI review requested due to automatic review settings June 10, 2026 13:06
@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: a258d6c0-d9fe-45b6-b96a-c7e58874a2e1

📥 Commits

Reviewing files that changed from the base of the PR and between dd657d0 and 1ee2c3c.

📒 Files selected for processing (7)
  • .github/workflows/docs.yml
  • .github/workflows/fips-compatibility.yml
  • .github/workflows/mutation-testing.yml
  • .github/workflows/python-compatibility.yml
  • .github/workflows/sonarcloud.yml
  • CHANGELOG.md
  • sonar-project.properties

Walkthrough

This PR fixes CI workflow and SonarCloud configuration issues by adding no-build: false to four reusable workflow invocations (docs, FIPS compatibility, mutation testing, Python compatibility), renaming the SonarCloud organization, and replacing unsupported wildcard patterns in test directory configuration with explicit paths.

Changes

CI Workflow and SonarCloud Configuration

Layer / File(s) Summary
Workflow no-build: false configuration across reusable invocations
.github/workflows/docs.yml, .github/workflows/fips-compatibility.yml, .github/workflows/mutation-testing.yml, .github/workflows/python-compatibility.yml
Four reusable workflow invocations receive explicit no-build: false input with inline comments explaining the hatchling editable root package installation constraint.
SonarCloud organization update and configuration fixes
.github/workflows/sonarcloud.yml, sonar-project.properties
SonarCloud workflow organization is renamed from williaby to byronwilliamscpa and receives no-build: false; sonar-project.properties converts wildcard test directory patterns to explicit enumerated paths.
CHANGELOG documentation
CHANGELOG.md
Unreleased section documents the no-build: false workflow input fixes and SonarCloud test directory pattern migration.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related issues

Possibly related PRs

Suggested labels

ci

Poem

A rabbit hops through workflows with care,
Build flags now set with fixes to spare,
SonarCloud paths listed out one by one,
CI chains fixed—the chase now is done! 🐰✨

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ci-no-build-optouts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates this repo’s GitHub Actions workflow callers to explicitly opt out of the org reusable workflows’ default --no-build behavior, which breaks editable installs for the hatchling-built root package when uv sync is run with --no-build.

Changes:

  • Set no-build: false for the python-docs, python-sonarcloud, python-fips-compatibility, python-mutation, and python-compatibility reusable-workflow callers.
  • Added short inline comments in each workflow explaining why no-build must be disabled for this repo.
  • Documented the CI workflow fix in CHANGELOG.md.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
CHANGELOG.md Documents the CI breakage cause and the no-build: false workaround applied to caller workflows.
.github/workflows/docs.yml Passes no-build: false to the org docs reusable workflow to allow editable install.
.github/workflows/sonarcloud.yml Passes no-build: false to the org SonarCloud reusable workflow to prevent uv sync --no-build failure.
.github/workflows/fips-compatibility.yml Passes no-build: false to the org FIPS compatibility reusable workflow to allow installation.
.github/workflows/mutation-testing.yml Passes no-build: false to the org mutation testing reusable workflow to avoid install failure.
.github/workflows/python-compatibility.yml Passes no-build: false to the org compatibility matrix reusable workflow to keep scheduled/PR runs working.

@codecov

codecov Bot commented Jun 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

williaby added 2 commits June 10, 2026 06:23
SonarCloud rejects wildcards in sonar.sources/sonar.tests; the
packages/*/tests/ entry failed the scan with exit code 3 once the
workflow was unbroken. List the four package test directories
explicitly.
The scanner 404'd on analysis creation because sonar-organization was
set to williaby, which has no python-libs project. The project key
ByronWilliamsCPA_python-libs exists in the byronwilliamscpa org
(confirmed via the SonarCloud components API).
@sonarqubecloud

Copy link
Copy Markdown

@williaby williaby merged commit e3ea1fc into main Jun 10, 2026
34 of 37 checks passed
@williaby williaby deleted the fix/ci-no-build-optouts branch June 10, 2026 13:38
@coderabbitai coderabbitai Bot added the ci label Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants