fix(ci): opt out of --no-build in org reusable workflow callers#50
Conversation
The org reusable workflows gained a no-build input defaulting to true, which passes --no-build to uv sync and fails on this repo's editable hatchling root package (no binary distribution). This broke the docs, SonarCloud, and FIPS runs on main and would break compatibility and mutation runs on their next schedule. Set no-build: false in all five callers, matching the sbom.yml fix merged in #44.
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (7)
WalkthroughThis PR fixes CI workflow and SonarCloud configuration issues by adding ChangesCI Workflow and SonarCloud Configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related issues
Possibly related PRs
Suggested labels
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Updates this repo’s GitHub Actions workflow callers to explicitly opt out of the org reusable workflows’ default --no-build behavior, which breaks editable installs for the hatchling-built root package when uv sync is run with --no-build.
Changes:
- Set
no-build: falsefor thepython-docs,python-sonarcloud,python-fips-compatibility,python-mutation, andpython-compatibilityreusable-workflow callers. - Added short inline comments in each workflow explaining why
no-buildmust be disabled for this repo. - Documented the CI workflow fix in
CHANGELOG.md.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| CHANGELOG.md | Documents the CI breakage cause and the no-build: false workaround applied to caller workflows. |
| .github/workflows/docs.yml | Passes no-build: false to the org docs reusable workflow to allow editable install. |
| .github/workflows/sonarcloud.yml | Passes no-build: false to the org SonarCloud reusable workflow to prevent uv sync --no-build failure. |
| .github/workflows/fips-compatibility.yml | Passes no-build: false to the org FIPS compatibility reusable workflow to allow installation. |
| .github/workflows/mutation-testing.yml | Passes no-build: false to the org mutation testing reusable workflow to avoid install failure. |
| .github/workflows/python-compatibility.yml | Passes no-build: false to the org compatibility matrix reusable workflow to keep scheduled/PR runs working. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
SonarCloud rejects wildcards in sonar.sources/sonar.tests; the packages/*/tests/ entry failed the scan with exit code 3 once the workflow was unbroken. List the four package test directories explicitly.
The scanner 404'd on analysis creation because sonar-organization was set to williaby, which has no python-libs project. The project key ByronWilliamsCPA_python-libs exists in the byronwilliamscpa org (confirmed via the SonarCloud components API).
|



Summary
The org reusable workflows gained a
no-buildinput defaulting totrue, which passes--no-buildtouv sync. That fails on this repo's editable hatchling root package:This is currently breaking the docs, SonarCloud, and FIPS runs on
main, and would break the compatibility and mutation runs on their next scheduled trigger.Changes
Set
no-build: false(the reusable workflows' own documented opt-out for hatchling projects) in all five callers:.github/workflows/docs.yml.github/workflows/sonarcloud.yml.github/workflows/fips-compatibility.yml.github/workflows/mutation-testing.yml.github/workflows/python-compatibility.ymlSame fix as applied to
sbom.ymlwithin #44 (commit a8e184b).Verification
sbom.ymlwith the identical fix went green on chore(deps): Update GitHub Actions #44 before merge.mainshould pass on their next run.Generated with Claude Code
Summary by CodeRabbit
Release Notes
Chores