Skip to content

Comments

Replace crosstermion/tui-react with direct ratatui + crossterm integration#318

Merged
Byron merged 1 commit intomainfrom
copilot/remove-crosstermion-tui-react
Feb 15, 2026
Merged

Replace crosstermion/tui-react with direct ratatui + crossterm integration#318
Byron merged 1 commit intomainfrom
copilot/remove-crosstermion-tui-react

Conversation

Copy link
Contributor

Copilot AI commented Feb 15, 2026

  • Review new PR feedback addressed to @copilot and identify required code changes
  • Add a small utility type with Drop to guarantee interactive terminal cleanup on early ? exits
  • Update interactive setup path to use the cleanup guard and keep current behavior
  • Run targeted interactive tests and formatting/lint checks
  • Capture/attach a UI screenshot for verification
  • Run code review and CodeQL scan

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Remove crosstermion and tui-react dependencies for ratatui Replace crosstermion/tui-react with direct ratatui + crossterm integration Feb 15, 2026
Copilot AI requested a review from Byron February 15, 2026 07:34
Comment on lines +95 to +96
enable_raw_mode().with_context(|| no_tty_msg)?;
execute!(stderr, EnterAlternateScreen).with_context(|| no_tty_msg)?;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot Wrap this in a utility type with Drop so it will definitely be cleaned up even if ? exits early between the rawmode + alternate screen, and the function calls that undo it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented in c710ff8. I wrapped the interactive terminal mode setup in an InteractiveTerminalGuard with Drop so raw mode + alternate screen are cleaned up on early ? exits as well, and explicitly drop the guard before process::exit on the normal path. Screenshot: https://github.com/user-attachments/assets/857fa87d-4ede-4fbb-9434-3bc97828291c

Copilot AI requested a review from Byron February 15, 2026 07:52
@Byron Byron marked this pull request as ready for review February 15, 2026 07:58
Co-authored-by: Byron <63622+Byron@users.noreply.github.com>
@Byron Byron force-pushed the copilot/remove-crosstermion-tui-react branch from c710ff8 to a1aaaa5 Compare February 15, 2026 07:59
@Byron Byron merged commit 7480277 into main Feb 15, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants