Replace crosstermion/tui-react with direct ratatui + crossterm integration#318
Merged
Replace crosstermion/tui-react with direct ratatui + crossterm integration#318
crosstermion/tui-react with direct ratatui + crossterm integration#318Conversation
Copilot
AI
changed the title
[WIP] Remove crosstermion and tui-react dependencies for ratatui
Replace Feb 15, 2026
crosstermion/tui-react with direct ratatui + crossterm integration
Byron
reviewed
Feb 15, 2026
Comment on lines
+95
to
+96
| enable_raw_mode().with_context(|| no_tty_msg)?; | ||
| execute!(stderr, EnterAlternateScreen).with_context(|| no_tty_msg)?; |
Owner
There was a problem hiding this comment.
@copilot Wrap this in a utility type with Drop so it will definitely be cleaned up even if ? exits early between the rawmode + alternate screen, and the function calls that undo it.
Contributor
Author
There was a problem hiding this comment.
Implemented in c710ff8. I wrapped the interactive terminal mode setup in an InteractiveTerminalGuard with Drop so raw mode + alternate screen are cleaned up on early ? exits as well, and explicitly drop the guard before process::exit on the normal path. Screenshot: https://github.com/user-attachments/assets/857fa87d-4ede-4fbb-9434-3bc97828291c
Co-authored-by: Byron <63622+Byron@users.noreply.github.com>
c710ff8 to
a1aaaa5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dropto guarantee interactive terminal cleanup on early?exits✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.