Skip to content

fix(tasks): attribute agent task updates correctly #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
moltar-bot merged 1 commit into from
Apr 21, 2026
Merged

fix(tasks): attribute agent task updates correctly #87

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
85 changes: 71 additions & 14 deletions api/src/routes/tasks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,20 @@ async function validateProjectContext(projectId, queryClient = pool) {
}

// Helper to log task events
function buildTaskActorMeta(user, meta = null) {
const mergedMeta = meta && typeof meta === 'object' && !Array.isArray(meta) ? { ...meta } : {};

if (user?.agent_id) {
mergedMeta.actor_type = 'agent';
mergedMeta.actor_agent_id = mergedMeta.actor_agent_id || user.agent_id;
mergedMeta.actor_name = mergedMeta.actor_name || user.name || user.agent_id;
} else if (user?.id) {
mergedMeta.actor_type = mergedMeta.actor_type || 'user';
}

return Object.keys(mergedMeta).length > 0 ? mergedMeta : null;
}

async function logTaskEvent(
client,
taskId,
Expand Down Expand Up @@ -615,7 +629,16 @@ router.post('/', optionalAuth, async (req, res, next) => {
preferred_model: newTask.preferred_model,
};

await logTaskEvent(client, newTask.id, 'CREATED', 'api', req.user?.id, null, newValues);
await logTaskEvent(
client,
newTask.id,
'CREATED',
'api',
req.user?.id,
null,
newValues,
buildTaskActorMeta(req.user),
);

await client.query('COMMIT');

Expand Down Expand Up @@ -964,7 +987,7 @@ router.put('/:id', optionalAuth, validateUUID('id'), async (req, res, next) => {
actorId,
JSON.stringify({ status: currentStatus }),
JSON.stringify({ attempted_status: status }),
JSON.stringify({ blocking_tasks: blockingTaskKeys }),
JSON.stringify(buildTaskActorMeta(req.user, { blocking_tasks: blockingTaskKeys })),
],
);
} catch (logError) {
Expand Down Expand Up @@ -1235,7 +1258,16 @@ router.put('/:id', optionalAuth, validateUUID('id'), async (req, res, next) => {
}
}

await logTaskEvent(client, id, eventType, 'api', req.user?.id, oldValues, newValues);
await logTaskEvent(
client,
id,
eventType,
'api',
req.user?.id,
oldValues,
newValues,
buildTaskActorMeta(req.user),
);

await client.query('COMMIT');

Expand Down Expand Up @@ -1428,15 +1460,24 @@ router.post('/:id/execution', optionalAuth, validateUUID('id'), async (req, res,
params,
);

await logTaskEvent(client, id, EXECUTION_EVENT_MAP[state], 'api', req.user?.id, null, null, {
state,
agent_id: normalizedAgentId ?? null,
session_key: normalizedSessionKey ?? null,
run_id: normalizedRunId ?? null,
branch: normalizedBranch ?? null,
pr_url: normalizedPrUrl ?? null,
note: note ? String(note).trim().slice(0, 2000) : null,
});
await logTaskEvent(
client,
id,
EXECUTION_EVENT_MAP[state],
'api',
req.user?.id,
null,
null,
buildTaskActorMeta(req.user, {
state,
agent_id: normalizedAgentId ?? null,
session_key: normalizedSessionKey ?? null,
run_id: normalizedRunId ?? null,
branch: normalizedBranch ?? null,
pr_url: normalizedPrUrl ?? null,
note: note ? String(note).trim().slice(0, 2000) : null,
}),
);

await client.query('COMMIT');

Expand Down Expand Up @@ -1492,11 +1533,19 @@ router.get('/:id/history', optionalAuth, validateUUID('id'), async (req, res, ne
`
SELECT
tl.*,
u.name as actor_name,
COALESCE(
u.name,
actor_agent.name,
tl.meta->>'actor_name',
tl.meta->>'actor_agent_id',
tl.meta->>'agent_id'
) as actor_name,
u.email as actor_email,
u.avatar_url as actor_avatar
FROM task_logs tl
LEFT JOIN users u ON tl.actor_id = u.id
LEFT JOIN agents actor_agent
ON actor_agent.agent_id = COALESCE(tl.meta->>'actor_agent_id', tl.meta->>'agent_id')
WHERE tl.task_id = $1
ORDER BY tl.occurred_at DESC
LIMIT $2 OFFSET $3
Expand Down Expand Up @@ -1590,7 +1639,13 @@ router.get('/:id/timeline', optionalAuth, validateUUID('id'), async (req, res, n
'event' AS type,
tl.event_type,
tl.actor_id,
u.name AS actor_name,
COALESCE(
u.name,
actor_agent.name,
tl.meta->>'actor_name',
tl.meta->>'actor_agent_id',
tl.meta->>'agent_id'
) AS actor_name,
u.email AS actor_email,
tl.occurred_at,
tl.meta,
Expand All @@ -1600,6 +1655,8 @@ router.get('/:id/timeline', optionalAuth, validateUUID('id'), async (req, res, n
tl.occurred_at AS occurred_at
FROM task_logs tl
LEFT JOIN users u ON u.id = tl.actor_id
LEFT JOIN agents actor_agent
ON actor_agent.agent_id = COALESCE(tl.meta->>'actor_agent_id', tl.meta->>'agent_id')
WHERE tl.task_id = $1
AND tl.event_type NOT IN ('COMMENT_CREATED', 'COMMENT_UPDATED', 'COMMENT_DELETED')`,
[id],
Expand Down
2 changes: 1 addition & 1 deletion web/src/pages/TaskManagerOverview.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ export default function TaskManagerOverview() {
const [activeTab, setActiveTab] = useState('live');
const [filterTypes, setFilterTypes] = useState([]);
const [filterAgents, setFilterAgents] = useState([]);
const [activityFilter, setActivityFilter] = useState('all'); // all | non-idle | running | active
const [activityFilter, setActivityFilter] = useState('non-idle'); // all | non-idle | running | active
const [groupBy, setGroupBy] = useState('kind'); // 'agent', 'kind', or 'none'
const [autoRefreshEnabled, setAutoRefreshEnabled] = useState(true);
const refreshInFlightRef = useRef(false);
Expand Down
Loading