Add macOS runner for building - #386
Open
emiyl wants to merge 2 commits into
Open
Conversation
Un1q32
reviewed
Aug 9, 2026
|
|
||
| build-glfw-macos-arm64: | ||
| name: Build (GLFW/macOS arm64) | ||
| runs-on: macos-latest |
Collaborator
There was a problem hiding this comment.
dont use -latest CI runners because if the version tied to it updates the compiler might update and introduce new warnings, and since we use -Werror it would break CI without warning
Un1q32
reviewed
Aug 9, 2026
|
|
||
| build-glfw-macos-x86_64: | ||
| name: Build (GLFW/macOS x86_64) | ||
| runs-on: macos-14 |
Collaborator
There was a problem hiding this comment.
use macos-26-intel and dont pass the -DCMAKE_OSX_ARCHITECTURES argument. You can omit all the sysctl stuff too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So we can see if macOS fails to build and also to provide users with macOS binaries from the actions if they don't want to compile it themselves c: