fix: composer ui in mobile#2377
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Visual recap — skippedThe visual recap job did not run for this pull request. This is informational only and does not block the PR. Recap skipped for |
There was a problem hiding this comment.
Builder reviewed your changes and has a few items to flag 🟡
Review Details
Incremental Code Review Summary
The latest commit addresses the previous review’s multi-file attachment issue: the picker still permits multiple files, but all returned assets are now converted with Promise.all and appended through addAttachments. No prior review thread requires resolution because that finding was not posted as an inline comment.
New Finding
🟡 MEDIUM: The redesigned bottom control row is a single non-wrapping flex row containing the plus control, model selector, mode selector, microphone, and send/stop control. On narrow supported devices (around 320px wide), a selected model/effort label can consume enough width that the rightmost send/stop control is pushed beyond the composer’s available width. The model/mode controls should be allowed to shrink/ellipsize or the row should reflow while preserving send/stop access.
The Expo dependency remains aligned with SDK 57, and the updated attachment conversion path is sound.
🧪 Browser testing: Skipped — infra-unavailable (the native Expo screen is not reachable from the running web dev server).
|
MUCH better, thanks @shivanshu11092003 ! |
fix mobile chat composer's control row to match our standard Claude composer.
Before
After