fix(content): stabilize database toolbar state#2370
Draft
3mdistal wants to merge 14 commits into
Draft
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
Visual recap — skippedThe visual recap job did not run for this pull request. This is informational only and does not block the PR. Recap skipped for |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Content database Sort and Filter menus now let Radix receive Escape and restore trigger focus. Personal filter/sort overrides hydrate before the toolbar becomes interactive, update their exact user-scoped cache entry, and survive ordinary, overlapping, reload, and out-of-order terminal saves.
Scope
update-content-database-personal-view.Implementation
@agent-native/corehas a patch changeset for the reusable user-setting mutation helper.Automated verification
Final SHA:
2f1af50ab6e9981e012a2c44d726439a6c81b75930049704196: fully green, including lint/format, typecheck, Content DB, full fast tests, build, scaffold E2E, Content parity, Core integration, security guards, SSR smoke, Plan E2E, Brain eval/privacy, and static QA.Real-browser acceptance still required before ready
A branch-matching Content deploy-preview exists for this SHA and reports
ready, but independent Chrome QA reachesERR_BLOCKED_BY_CLIENT; the in-app browser is unavailable. Framework preflight also reportsteenylilframeworkoffline with SSH timeout. No fixture was created and no application/user data was written.The frozen matrix is therefore unproven, not passed: ordinary full-page owner/editor, viewer keyboard/no-write, inline database, source-backed database, and Board mode. For each applicable surface, capture pointer plus Enter/Space/ArrowDown, ARIA/open state, Escape/focus, zero write on open, exactly one personal override on selection, reload persistence, unchanged shared/source state, and clean console/network evidence. Setup and cleanup must use safe actions.
Exact unblock: an accessible browser session for the same deploy-preview or a reachable Framework runtime built from this SHA, plus safe disposable action-backed fixtures and owner/editor/viewer access.
Risk
System-ready, no feature flag. Keep draft until the real-browser matrix is green. No merge requested.