Repository navigation
Default action API host to apex (buildpulse.io) - #8
Conversation
Apex cutover deep-link update: DEFAULT_API_HOST app2.buildpulse.io -> buildpulse.io. The signed-upload-URL endpoint (/api/test-results/upload-url) is served identically at the apex (verified: 401 auth-required, same as app2), since both resolve to the same CloudFront -> web-client. Only affects new runs that don't set api-host / BUILDPULSE_API_HOST. app2.buildpulse.io stays alive, so pinned older releases keep working. Regenerated dist/ via ncc; tests pass. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
loera140
left a comment
There was a problem hiding this comment.
Agent code review
Walkthrough
Apex cutover for the action's default API host: DEFAULT_API_HOST in src/upload.js moves from https://app2.buildpulse.io to https://buildpulse.io, and the matching positive-case assertion in src/__tests__/enforceHttps.test.js is updated in lockstep. dist/index.js and its source map are regenerated via ncc. Only affects runs that do not set api-host / BUILDPULSE_API_HOST; PR body documents that app2.buildpulse.io stays alive so pinned releases keep working, and that /api/test-results/upload-url returns identical 401 (auth-required) at both hosts.
Findings
- No issues found.
Notes that did not rise to a finding:
- The huge
dist/index.jschurn (~17k+/~21k-) is almost entirely a bundled-undiciswap (EnvHttpProxyAgent/RetryAgent/interceptors/EventSource/fetchrewiring). The lockfile pinsundici@5.29.0and the rebuilt bundle is consistent with that pin; the priormaindist appears to have been built against a newer undici than the lockfile specifies, so this rebuild restores lockfile/dist consistency. None of the swapped surface area is referenced bysrc/(the action's HTTP code uses Node's built-inhttps.request, not undici/@actions/http-client), so this delta is runtime-inert for the action itself. - Only changed lines available for inline comments are inside
dist/index.js; no actionable comment to anchor there.
Verdict
APPROVE. The semantic change is a one-line default-host swap fully covered by the existing enforceHttps test, with the test updated to match. PR title matches the diff, scope is tight, app2 stays alive as the rollback path (customers re-pin a prior tag), no tests removed or weakened, no hallucinated APIs, no prompt-injection content. CI gate is green.
Confidence
HIGH — Read both source files in full, confirmed no other app2.buildpulse.io references remain, validated the dist/ delta is a benign undici rebuild against the existing lockfile, and verified the action does not import undici-specific surface area in source.
Apex cutover deep-link update:
DEFAULT_API_HOSTapp2.buildpulse.io→buildpulse.io. The/api/test-results/upload-urlendpoint is served identically at the apex (verified 401 auth-required, same as app2). Only affects runs that do not setapi-host/BUILDPULSE_API_HOST;app2stays alive so pinned releases keep working. Regenerateddist/via ncc; 31 tests pass. A new tagged release is required for customers to pick this up.🤖 Generated with Claude Code