Skip to content

Default action API host to apex (buildpulse.io) - #8

Merged
loera140 merged 1 commit into
mainfrom
feat/apex-default-api-host
Jun 6, 2026
Merged

loera140 merged 1 commit into
mainfrom
feat/apex-default-api-host

Conversation

@loera140

@loera140 loera140 commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

Apex cutover deep-link update: DEFAULT_API_HOST app2.buildpulse.io→buildpulse.io. The /api/test-results/upload-url endpoint is served identically at the apex (verified 401 auth-required, same as app2). Only affects runs that do not set api-host/BUILDPULSE_API_HOST; app2 stays alive so pinned releases keep working. Regenerated dist/ via ncc; 31 tests pass. A new tagged release is required for customers to pick this up.

🤖 Generated with Claude Code

Apex cutover deep-link update: DEFAULT_API_HOST app2.buildpulse.io ->
buildpulse.io. The signed-upload-URL endpoint (/api/test-results/upload-url)
is served identically at the apex (verified: 401 auth-required, same as
app2), since both resolve to the same CloudFront -> web-client.

Only affects new runs that don't set api-host / BUILDPULSE_API_HOST.
app2.buildpulse.io stays alive, so pinned older releases keep working.
Regenerated dist/ via ncc; tests pass.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@buildpulse-agent buildpulse-agent Bot added agent-review-pending Agent code-review dispatched; verdict in flight labels Jun 6, 2026
@loera140 loera140 added agent-reviewed Reviewed - approved and removed agent-review-pending Agent code-review dispatched; verdict in flight labels Jun 6, 2026

@loera140 loera140 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agent code review

Walkthrough

Apex cutover for the action's default API host: DEFAULT_API_HOST in src/upload.js moves from https://app2.buildpulse.io to https://buildpulse.io, and the matching positive-case assertion in src/__tests__/enforceHttps.test.js is updated in lockstep. dist/index.js and its source map are regenerated via ncc. Only affects runs that do not set api-host / BUILDPULSE_API_HOST; PR body documents that app2.buildpulse.io stays alive so pinned releases keep working, and that /api/test-results/upload-url returns identical 401 (auth-required) at both hosts.

Findings

  • No issues found.

Notes that did not rise to a finding:

  • The huge dist/index.js churn (~17k+/~21k-) is almost entirely a bundled-undici swap (EnvHttpProxyAgent/RetryAgent/interceptors/EventSource/fetch rewiring). The lockfile pins undici@5.29.0 and the rebuilt bundle is consistent with that pin; the prior main dist appears to have been built against a newer undici than the lockfile specifies, so this rebuild restores lockfile/dist consistency. None of the swapped surface area is referenced by src/ (the action's HTTP code uses Node's built-in https.request, not undici/@actions/http-client), so this delta is runtime-inert for the action itself.
  • Only changed lines available for inline comments are inside dist/index.js; no actionable comment to anchor there.

Verdict

APPROVE. The semantic change is a one-line default-host swap fully covered by the existing enforceHttps test, with the test updated to match. PR title matches the diff, scope is tight, app2 stays alive as the rollback path (customers re-pin a prior tag), no tests removed or weakened, no hallucinated APIs, no prompt-injection content. CI gate is green.

Confidence

HIGH — Read both source files in full, confirmed no other app2.buildpulse.io references remain, validated the dist/ delta is a benign undici rebuild against the existing lockfile, and verified the action does not import undici-specific surface area in source.

@loera140
loera140 merged commit 9e258c8 into main Jun 6, 2026
2 checks passed
@loera140
loera140 deleted the feat/apex-default-api-host branch June 6, 2026 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-reviewed Reviewed - approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant