Repository navigation
docs: sync EXTERNAL-VOICE.md with the entity-dash rule - #14
Conversation
Our own PR reviewer caught an `—` rendering as a visible em-dash on the Runners pricing page while the guard passed clean, because the entity is seven ASCII bytes and nothing was looking for it. The canonical doc now bans the entity forms explicitly and explains the second reason they are worse than the literal character: inside a multi-line JSX text run an entity makes the transform drop the space after an adjacent expression. The doc also now states the known gap plainly, that the in-product dashboard copy in web-client is in scope but not yet swept, so a green guard is not read as the whole product being clean. Doc-only, and identical to the copies in the other three repos. No entity dashes exist in this repo; this keeps the four copies from drifting. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Agent code review
Walkthrough
This is a documentation-only PR that adds 17 lines to EXTERNAL-VOICE.md, the canonical em-dash style rule shared across four repos. The two additions are: (1) an explicit ban on HTML entity forms of dash characters (—, —, —, spaced –) with rationale, and (2) a "Known gap" section at the end of the Enforcement table honestly documenting ~90 un-swept literal em-dashes remaining in the web-client/src/app/organizations/** dashboard copy. No code is changed.
Findings
No issues found.
Verdict
Clean, well-reasoned documentation update. The entity-dash paragraph closes a real gap (ASCII-invisible to character searches), and the "Known gap" section sets accurate expectations without overstating coverage. The prose is clear and consistent with the existing file's register. One changed file, fully read. Pre-APPROVE checklist all green.
Confidence
HIGH — single doc-only file, complete diff read, no code logic involved.
💡 Tips for working with the BuildPulse reviewer
- Re-review on demand — comment
@buildpulse reviewon the PR (/buildpulse reviewalso works). The fresh review bills the requester's seat. - Teach it by replying to a finding — reply to any inline comment: "we never do X here" becomes a standing rule for this repository (acknowledged in-thread, not raised again); "not in this PR" mutes the topic for this PR only. Replies are free. Org admins can view or remove learned rules on the AI Features page.
- Every push is re-reviewed automatically — smaller PRs get a fresh full review, larger ones get a delta review of what changed since the last look; an "Update branch" merge with an unchanged diff carries the previous verdict forward without a new billed review.
- Draft PRs are skipped until marked ready for review (repositories can opt in to draft reviews on the AI Features page).
docs: sync EXTERNAL-VOICE.md with the entity-dash rule
Our own PR reviewer caught an
—rendering as a visible em-dash on theRunners pricing page while the guard passed clean, because the entity is seven
ASCII bytes and nothing was looking for it. The canonical doc now bans the
entity forms explicitly and explains the second reason they are worse than the
literal character: inside a multi-line JSX text run an entity makes the
transform drop the space after an adjacent expression.
The doc also now states the known gap plainly, that the in-product dashboard
copy in web-client is in scope but not yet swept, so a green guard is not read
as the whole product being clean.
Doc-only, and identical to the copies in the other three repos. No entity dashes
exist in this repo; this keeps the four copies from drifting.
Co-Authored-By: Claude Opus 5 (1M context) noreply@anthropic.com