Skip to content

fix: remove the unused mongodb_uri variable and MONGODB_URI pass-through - #66

Merged
buildpulser merged 1 commit into
mainfrom
fix/remove-unused-mongodb-uri-secret
Oct 14, 2026
Merged

buildpulser merged 1 commit into
mainfrom
fix/remove-unused-mongodb-uri-secret

Conversation

@buildpulser

Copy link
Copy Markdown
Member

What

Removes leftovers from #65, which moved mcp-remote's MONGODB_URI to the environment remote state (documentdb.ecs_replica_set_uri):

No change to what is deployed: the task definition already takes MONGODB_URI from remote state, so the Terraform plan should show no resource changes.

After merge

The MONGODB_URI repository secret is then unreferenced. It holds the old directConnection=true connection string, credential included, so it should be deleted:

gh secret delete MONGODB_URI --repo BuildPulseLLC/buildpulse-mcp

🤖 Generated with Claude Code

MONGODB_URI has come from the environment remote state
(documentdb.ecs_replica_set_uri) since #65; the Terraform variable and
the workflow's TF_VAR_mongodb_uri pass-through were left only so the
deploy kept working while the secret existed. Removes both, the comment
that described the old value, and the README row that said mcp-remote
has no DB access (it writes mcpSessions).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@buildpulse-v2 buildpulse-v2 Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agent code review

Walkthrough

This PR completes the cleanup from #65, which migrated MONGODB_URI to come from the environment Terraform remote state (documentdb.ecs_replica_set_uri) instead of a repository secret. Three artifacts left behind by that migration are now removed: (1) the TF_VAR_mongodb_uri env block in the deploy job, (2) the now-dead mongodb_uri Terraform variable (which was already marked UNUSED with default = ""), and (3) the stale comment in main.tf describing the old secret-based sourcing. A fourth change corrects the README table, which previously said mcp-remote has no DB access — it does write mcpSessions via MONGODB_URI.

Findings

No issues found.

Verdict

Clean, scoped removal of dead scaffolding. The mongodb_uri Terraform variable and TF_VAR_mongodb_uri workflow env var were already inert (variable had default = "", value was never consumed by any resource), so removing them carries zero runtime risk. git grep confirms no remaining references to these symbols anywhere in the repo. The README correction is accurate — mcp-remote does write mcpSessions to DocumentDB. All four changed files read and verified.

Confidence

HIGH — all four changed files were read in full; the removed symbols were confirmed absent from the rest of the codebase.

💡 Tips for working with the BuildPulse reviewer
  • Re-review on demand — comment @buildpulse review on the PR (/buildpulse review also works). The fresh review bills the requester's seat.
  • Teach it by replying to a finding — reply to any inline comment: "we never do X here" becomes a standing rule for this repository (acknowledged in-thread, not raised again); "not in this PR" mutes the topic for this PR only. Replies are free. Org admins can view or remove learned rules on the AI Features page.
  • Every push is re-reviewed automatically — smaller PRs get a fresh full review, larger ones get a delta review of what changed since the last look; an "Update branch" merge with an unchanged diff carries the previous verdict forward without a new billed review.
  • Draft PRs are skipped until marked ready for review (repositories can opt in to draft reviews on the AI Features page).

@buildpulser
buildpulser merged commit 8029af9 into main Oct 14, 2026
5 checks passed
@buildpulser
buildpulser deleted the fix/remove-unused-mongodb-uri-secret branch October 14, 2026 23:06

This branch was previously deployed

1 inactive deployment
development — 6d77cf41 Deployed Oct 14, 2026 by buildpulser via deploy #142
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-reviewed Reviewed - approved

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant