Repository navigation
fix: remove the unused mongodb_uri variable and MONGODB_URI pass-through - #66
Conversation
MONGODB_URI has come from the environment remote state (documentdb.ecs_replica_set_uri) since #65; the Terraform variable and the workflow's TF_VAR_mongodb_uri pass-through were left only so the deploy kept working while the secret existed. Removes both, the comment that described the old value, and the README row that said mcp-remote has no DB access (it writes mcpSessions). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Agent code review
Walkthrough
This PR completes the cleanup from #65, which migrated MONGODB_URI to come from the environment Terraform remote state (documentdb.ecs_replica_set_uri) instead of a repository secret. Three artifacts left behind by that migration are now removed: (1) the TF_VAR_mongodb_uri env block in the deploy job, (2) the now-dead mongodb_uri Terraform variable (which was already marked UNUSED with default = ""), and (3) the stale comment in main.tf describing the old secret-based sourcing. A fourth change corrects the README table, which previously said mcp-remote has no DB access — it does write mcpSessions via MONGODB_URI.
Findings
No issues found.
Verdict
Clean, scoped removal of dead scaffolding. The mongodb_uri Terraform variable and TF_VAR_mongodb_uri workflow env var were already inert (variable had default = "", value was never consumed by any resource), so removing them carries zero runtime risk. git grep confirms no remaining references to these symbols anywhere in the repo. The README correction is accurate — mcp-remote does write mcpSessions to DocumentDB. All four changed files read and verified.
Confidence
HIGH — all four changed files were read in full; the removed symbols were confirmed absent from the rest of the codebase.
💡 Tips for working with the BuildPulse reviewer
- Re-review on demand — comment
@buildpulse reviewon the PR (/buildpulse reviewalso works). The fresh review bills the requester's seat. - Teach it by replying to a finding — reply to any inline comment: "we never do X here" becomes a standing rule for this repository (acknowledged in-thread, not raised again); "not in this PR" mutes the topic for this PR only. Replies are free. Org admins can view or remove learned rules on the AI Features page.
- Every push is re-reviewed automatically — smaller PRs get a fresh full review, larger ones get a delta review of what changed since the last look; an "Update branch" merge with an unchanged diff carries the previous verdict forward without a new billed review.
- Draft PRs are skipped until marked ready for review (repositories can opt in to draft reviews on the AI Features page).
What
Removes leftovers from #65, which moved
mcp-remote'sMONGODB_URIto the environment remote state (documentdb.ecs_replica_set_uri):mongodb_uriTerraform variable (unused since Read the DocumentDB connection string from the environment remote state, in replica set mode #65, kept only so the pass-through below did not fail)TF_VAR_mongodb_uri: ${{ secrets.MONGODB_URI }}pass-through.infra/main.tfcomment describing the old value.infra/README.mdrow that said mcp-remote has no DB access (it writesmcpSessions)No change to what is deployed: the task definition already takes
MONGODB_URIfrom remote state, so the Terraform plan should show no resource changes.After merge
The
MONGODB_URIrepository secret is then unreferenced. It holds the olddirectConnection=trueconnection string, credential included, so it should be deleted:🤖 Generated with Claude Code