Repository navigation
extract helpers to reduce duplication and improve readability - #82
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #82 +/- ##
=======================================
Coverage 98.71% 98.71%
=======================================
Files 4 4
Lines 233 233
=======================================
Hits 230 230
Misses 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BuczynskiRafal
added a commit
that referenced
this pull request
Sep 30, 2026
Resolve the views.py conflict with the helper extraction from #82 and #83. The branch had rewritten the run views, the upload flow and the comparison, so those keep the branch's code; #83's concise docstrings, %-style logging, _get_download_payload, _file_too_large_message, _timestamp_suffix and the profile form helpers are kept. Helpers the branch replaced (the example.inp fallback, the upload session reset, _store_result_payload_for_user, the timeseries defaults) are dropped, and _store_upload removes the previous upload again, which #82 had moved into one of them.
BuczynskiRafal
added a commit
that referenced
this pull request
Sep 30, 2026
Resolve the views.py conflict with the helper extraction from #82 and #83. The branch had rewritten the run views, the upload flow and the comparison, so those keep the branch's code; #83's concise docstrings, %-style logging, _get_download_payload, _file_too_large_message, _timestamp_suffix and the profile form helpers are kept. Helpers the branch replaced (the example.inp fallback, the upload session reset, _store_result_payload_for_user, the timeseries defaults) are dropped, and _store_upload removes the previous upload again, which #82 had moved into one of them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.