Fix unclickable switch center / Rebase PR 630#675
Open
FirstVertex wants to merge 3 commits intoBttstrp:masterfrom
Open
Fix unclickable switch center / Rebase PR 630#675FirstVertex wants to merge 3 commits intoBttstrp:masterfrom
FirstVertex wants to merge 3 commits intoBttstrp:masterfrom
Conversation
This change fixes a long-standing issue with the white portion of the Off switch being not clickable. Issues reported on it here: Bttstrp#481 and here: Bttstrp#628 and here, all the same bug, reported since couple of years Bttstrp#467 Plunker to demonstrate bug (uses existing code) https://plnkr.co/edit/wXJvctugqNAx00rgUfeg?p=preview Plunker to demonstrate fix (uses this fork) https://plnkr.co/edit/DY1Icvv4HyDi2D0PkfdU?p=preview When using these Plunkers, set the switch to Off state. Try clicking on the white part of the switch (the part that doesn't say "Off") - notice that it does not switch off in the first Plunker (with bug) and that it correctly switches off in the second Plunker (with my fix)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes a long-standing issue with the white portion of the Off switch being not clickable.
Issues reported on it here:
#481
and here:
#628
and here, all the same bug, reported since couple of years
#467
Plunker to demonstrate bug (uses existing code)
https://plnkr.co/edit/wXJvctugqNAx00rgUfeg?p=preview
Plunker to demonstrate fix (uses this fork)
https://plnkr.co/edit/DY1Icvv4HyDi2D0PkfdU?p=preview
When using these Plunkers, set the switch to Off state. Try clicking on the white part of the switch (the part that doesn't say "Off") - notice that it does not switch off in the first Plunker (with bug) and that it correctly switches off in the second Plunker (with my fix)