Skip to content

Allow effects to persist between minigame changes - #36

Merged
Brollyy merged 5 commits into
masterfrom
feature/issue-34-persist-effects
Sep 8, 2026
Merged

Brollyy merged 5 commits into
masterfrom
feature/issue-34-persist-effects

Conversation

@Brollyy

@Brollyy Brollyy commented Sep 6, 2026

Copy link
Copy Markdown
Owner

Summary

  • Add a backward-compatible persist_between_minigames property to every visual-effect template.
  • When enabled, camera transforms, flips, zoom, overlays, pixelation, and HSL/Sepia requests detect an active-camera change and rebind to the new camera.
  • Old camera state is removed before the new camera is attached, preventing stale transforms and duplicate overlays.
  • Missing properties default to false; playback stop/pause still calls StopAllEffects and clears persistent runners.
  • Document the new property for all effects.

Validation

  • Built against the installed Bits & Bops game assemblies.
  • Build result: 0 warnings, 0 errors.
  • git diff --check passes.

Closes #34.

@Brollyy Brollyy left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just the name of the param is too long, replace everywhere with shorter variant

@Brollyy
Brollyy merged commit 0a613f9 into master Sep 8, 2026
6 checks passed
@Brollyy
Brollyy deleted the feature/issue-34-persist-effects branch September 8, 2026 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow effects to persist between minigame changes

1 participant