Repository navigation
Launch Bifrost with source admission settings for real repositories - #204
Merged
Merged
Conversation
The real-project-v1 TypeScript documents (typescript-01, -02, -04) have failed since the 2026-10-04 run with unavailable_canonical_facts. Bifrost's JS/TS usage index needs canonical facts for every file, and each of these repositories holds one valid source file that Bifrost's interactive defaults refuse to parse: a raw NUL inside a string literal (tailwindcss, paperclip) or a 16,621-byte JSX SVG path line (excalidraw). The benchmark measures usage lookup on repositories as written, so the runner now launches Bifrost with BIFROST_MAX_LINE_LENGTH=0 and BIFROST_ADMIT_NUL_BYTES=1. Bifrost's own defaults stay unchanged. A Bifrost revision that predates a setting ignores it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The Bifrost runner now launches the server with
BIFROST_MAX_LINE_LENGTH=0andBIFROST_ADMIT_NUL_BYTES=1. README and the reproduce guide document both settings.Why
real-project-v1/typescript-01,-02and-04have failed since the 2026-10-04 run withunavailable_canonical_facts. In each repository, Bifrost's interactive defaults refuse one valid source file: a raw NUL inside a string literal (tailwindcss, paperclip) or a 16,621-byte JSX SVG path line (excalidraw). A single refused file makes the whole JS/TS usage index unavailable. The benchmark measures repositories as written, so it admits these files. Bifrost's own defaults stay unchanged.BIFROST_ADMIT_NUL_BYTESis new in BrokkAi/bifrost-dev#5870. A Bifrost revision that predates a setting ignores it.Validation
With a debug build of BrokkAi/bifrost-dev#5870 (
--bifrost-binary): typescript-01 3/3 (12 TP), typescript-02 3/3 (21 TP), typescript-04 3/3 (11 TP), with 0 FP and 0 FN.cargo buildandcargo fmtare clean.🤖 Generated with Claude Code