dialog-confirm: native: fix overflow edge cases#7007
Conversation
| ${buttons} | ||
| </d2l-dialog-confirm> | ||
| ` }, | ||
| { name: 'slighty-larger-critical', template: html` |
There was a problem hiding this comment.
Note that I ran these tests on the main branch before running on this branch to confirm bug then fix but I could not get this one to fail as expected on main (it looked correct; within the demo it was broken)
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
Note The build needs to finish before your changes are deployed. |
| } | ||
|
|
||
| dialog.d2l-dialog-outer.d2l-dialog-outer-full-height { | ||
| height: auto; |
There was a problem hiding this comment.
I'm guessing these are also to override UA styles...?
There was a problem hiding this comment.
That's correct. I can add comments on them as well.
There was a problem hiding this comment.
Sounds good. I think they might help "future-us".
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…tually be necessary
|
🎉 This PR is included in version 3.253.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
2 participants
GAUD-10063
This fixes 2 overflow issues when using native dialogs with dialog-confirm:
Expected/post-fix behaviour for (1):
Expected/post-fix behaviour for (2):
