GAUD-9841: added autocomplete off to input-date#7004
Merged
maxkrivodonova merged 3 commits intoMay 20, 2026
Conversation
Contributor
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
Note The build needs to finish before your changes are deployed. |
EdwinACL831
reviewed
May 20, 2026
| <d2l-input-text | ||
| ?novalidate="${this.noValidate}" | ||
| aria-invalid="${this.invalid ? 'true' : 'false'}" | ||
| autocomplete="off" |
Contributor
There was a problem hiding this comment.
I would just maybe add a unit test asserting that this element has this option as off
dlockhart
reviewed
May 20, 2026
dlockhart
approved these changes
May 20, 2026
Member
dlockhart
left a comment
dlockhart
left a comment
There was a problem hiding this comment.
Looks good! Don't forget the fix: <message> in the merge/squash commit to release.
maxkrivodonova
deleted the
mkrivodonova/GAUD-9841-disable-autocomplete-dates
branch
|
🎉 This PR is included in version 3.252.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://desire2learn.atlassian.net/browse/GAUD-9841
The input box of a date component shouldn't have autocomplete.