Skip to content

GAUD-8847: Remove checkbox.scss#6964

Merged
EdwinACL831 merged 11 commits into
mainfrom
ecollazos/GAUD-8847_remove_checkbox_scss
May 14, 2026
Merged

GAUD-8847: Remove checkbox.scss#6964
EdwinACL831 merged 11 commits into
mainfrom
ecollazos/GAUD-8847_remove_checkbox_scss

Conversation

@EdwinACL831
Copy link
Copy Markdown
Contributor

@EdwinACL831 EdwinACL831 commented May 11, 2026

Jira

GAUD-8847

Description

Asper we want to remove the scss styles for the checkbox we had to:

  • remove the checkbox.scss file
  • remove the d2l-test-input-checkbox class from the sass.scss file
  • remove any test related to the sass.scss

These are the three steps needed in order to accomplish the goal in the very least disruptive way

  • 1. Only merge the changes related to the new way of getting the styles (this PR essentially).
  • 2. In the BSI project, enable to use the new way of getting the styles without getting rid from the sass logic yet
  • 3. Remove the sass logic in Core and in BSI repos.

Related PRs


});

describe('sass', () => {
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests were asserting the sass file which contains the sass generated d2l-test-input-checkbox class. Since it is not going to be generated any more, these tests make no sense now.

@github-actions
Copy link
Copy Markdown
Contributor

Thanks for the PR! 🎉

We've deployed an automatic preview for this PR - you can see your changes here:

URL https://live.d2l.dev/prs/BrightspaceUI/core/pr-6964/

Note

The build needs to finish before your changes are deployed.
Changes to the PR will automatically update the instance.

Comment thread package-lock.json
@EdwinACL831 EdwinACL831 marked this pull request as ready for review May 11, 2026 18:07
@EdwinACL831 EdwinACL831 requested a review from a team as a code owner May 11, 2026 18:07
Comment thread components/inputs/sass/checkbox.scss
Comment thread components/inputs/input-checkbox-styles.js
Copy link
Copy Markdown
Member

@dlockhart dlockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! I think it'll be easier though to break your change into two. That way you can update BSI without breaking it.

  1. Add this new _generateInputCheckboxStyles function to checkbox styles & update core things to use it (most of this PR)
  2. Update BSI to use _generateInputCheckboxStyles instead of the Sass
  3. Remove the Sass checkbox stuff from core

Comment thread helpers/test/css.test.js
Copy link
Copy Markdown
Member

@dlockhart dlockhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EdwinACL831 EdwinACL831 enabled auto-merge (squash) May 14, 2026 20:47
@EdwinACL831 EdwinACL831 merged commit f783908 into main May 14, 2026
8 checks passed
@EdwinACL831 EdwinACL831 deleted the ecollazos/GAUD-8847_remove_checkbox_scss branch May 14, 2026 21:01
@d2l-github-release-tokens
Copy link
Copy Markdown

🎉 This PR is included in version 3.251.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants