GAUD-8847: Remove checkbox.scss#6964
Merged
Merged
Conversation
added 2 commits
May 11, 2026 13:52
- Updates package-lock.json file
EdwinACL831
commented
May 11, 2026
|
|
||
| }); | ||
|
|
||
| describe('sass', () => { |
Contributor
Author
There was a problem hiding this comment.
These tests were asserting the sass file which contains the sass generated d2l-test-input-checkbox class. Since it is not going to be generated any more, these tests make no sense now.
Contributor
|
Thanks for the PR! 🎉 We've deployed an automatic preview for this PR - you can see your changes here:
Note The build needs to finish before your changes are deployed. |
EdwinACL831
commented
May 11, 2026
dlockhart
reviewed
May 11, 2026
added 2 commits
May 11, 2026 16:15
dlockhart
reviewed
May 12, 2026
dlockhart
reviewed
May 13, 2026
Member
dlockhart
left a comment
There was a problem hiding this comment.
This is looking good! I think it'll be easier though to break your change into two. That way you can update BSI without breaking it.
- Add this new
_generateInputCheckboxStylesfunction to checkbox styles & update core things to use it (most of this PR) - Update BSI to use
_generateInputCheckboxStylesinstead of the Sass - Remove the Sass checkbox stuff from core
added 5 commits
May 13, 2026 16:41
…elated to the new way of generating styles
|
🎉 This PR is included in version 3.251.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira
GAUD-8847
Description
Asper we want to remove the scss styles for the checkbox we had to:
checkbox.scssfiled2l-test-input-checkboxclass from thesass.scssfileThese are the three steps needed in order to accomplish the goal in the very least disruptive way
Related PRs