Skip to content

GAUD-9165 - Example of how we could apply fix to our sticky components #6911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
svanherk wants to merge 6 commits into from
Closed

GAUD-9165 - Example of how we could apply fix to our sticky components #6911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7f3dfc8
GAUD-9165 - Implement the d2l-page skeleton
svanherk May 1, 2026
5994bb7
Linting fixes
svanherk May 1, 2026
4c09b8b
Stacking context adjustments
svanherk May 4, 2026
67d42fd
GAUD-9165 - Flesh out the demo page to be more realistic and include …
svanherk May 4, 2026
2c5444a
Add dialog demonstrating stacking context issue, since dialogs don't …
svanherk May 4, 2026
82e9355
GAUD-9165 - Example of how we could apply fix to our sticky components
svanherk May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions components/collapsible-panel/collapsible-panel.js
View file
Open in desktop
Copy link
Copy Markdown
Contributor Author

@svanherk svanherk May 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why collapsible-panel is set up this way, it's confusing. I think this is a good fix regardless, but maybe the vdiffs will disagree.

Copy link
Copy Markdown
Member

@dlockhart dlockhart May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like mostly very subtle anti-aliasing changes -- but there are some issues with "inline" panels that are focused.

Copy link
Copy Markdown
Contributor Author

@svanherk svanherk May 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah not as bad as I thought, if we go this route we'll need to dig more. This change would align collapsible-panel to work how the list controls work - applying certain styles when it sticks, not suddenly deciding to make it sticky.

Original file line number Diff line number Diff line change
Expand Up @@ -173,15 +173,17 @@ class CollapsiblePanel extends SkeletonMixin(FocusMixin(LitElement)) {
border-radius: 0;
outline-offset: -2px;
}
.d2l-collapsible-panel.scrolled .d2l-collapsible-panel-header {
.d2l-collapsible-panel .d2l-collapsible-panel-header {
background-color: var(--d2l-theme-background-color-base);
box-shadow: 0 8px 12px -9px rgba(0, 0, 0, 0.3);
position: sticky;
top: 0;
top: var(--d2l-sticky-offset, 0px);
z-index: 11; /* must be greater greater than list-items with open dropdowns or tooltips */
}
.d2l-collapsible-panel.scrolled .d2l-collapsible-panel-header {
box-shadow: 0 8px 12px -9px rgba(0, 0, 0, 0.3);
}
.d2l-collapsible-panel.focused.scrolled .d2l-collapsible-panel-header {
top: 2px;
top: calc(var(--d2l-sticky-offset, 0px) + 2px);
}
.d2l-collapsible-panel-title {
flex: 1;
Expand Down
5 changes: 5 additions & 0 deletions components/page/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
# Page

The `d2l-page` and page layout components are in progress.

Please reach out before using them!
Loading
Loading