fix: remove invalid is_tokenized parameter from ConllParser#38
Open
awanawana wants to merge 1 commit intoBramVanroy:masterfrom
Open
fix: remove invalid is_tokenized parameter from ConllParser#38awanawana wants to merge 1 commit intoBramVanroy:masterfrom
awanawana wants to merge 1 commit intoBramVanroy:masterfrom
Conversation
The is_tokenized parameter is already handled by init_parser() and passed to the underlying spaCy pipeline. ConllParser is a dataclass that only accepts 'nlp' as its constructor argument. Fixes BramVanroy#30 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #30
The CLI's
parse()function was passingis_tokenized=args.is_tokenizedtoConllParser(), butConllParseris a dataclass that only acceptsnlpas its constructor argument.The
is_tokenizedparameter is already correctly handled byinit_parser()(lines 14-21), which configures the underlying spaCy pipeline with tokenization settings. The parameter should not be passed again toConllParser.Changes
is_tokenizedkeyword argument fromConllParser()call incli/parse.pyTest
🤖 Generated with Claude Code