fix(cart): preserve separate cart lines per batch for batch-tracked items#281
Open
souravs72 wants to merge 1 commit into
Open
fix(cart): preserve separate cart lines per batch for batch-tracked items#281souravs72 wants to merge 1 commit into
souravs72 wants to merge 1 commit into
Conversation
Cart merge matched item_code + UOM only, so a second batch overwrote the first line and only one batch reached the Sales Invoice. Match lines by batch_no, add ERPNext-aligned auto-allocation for multi-batch qty, and scope cart update/remove to the correct batch line. Fixes BrainWise-DEV#266
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug where adding the same batch-tracked item from two different batches would silently merge them into a single cart line — meaning only one batch ever made it onto the Sales Invoice.
Root cause
If you added a batch-tracked item, picked Batch 1, then added it again and picked Batch 2, the cart would just update the existing line's quantity instead of creating a second one. By the time the invoice was submitted, whichever batch you picked last was the only one recorded. The first batch was completely lost.
The root cause was straightforward: useInvoice.addItem was matching existing cart rows by item_code + uom only - it never looked at batch_no.
Reproduce
Before: One cart line, one invoice row. Last batch wins, first batch gone.
*After: Two separate cart lines, two invoice rows, both batches preserved.