Skip to content

pass currency context for barcode item lookup #277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lubshad wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

pass currency context for barcode item lookup #277

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions pos_next/api/items.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,10 +233,14 @@ def get_item_detail(item, doc=None, warehouse=None, price_list=None, company=Non
)

item["price_list_currency"] = price_list_currency
item["currency"] = company_currency
item["plc_conversion_rate"] = exchange_rate
item["conversion_rate"] = exchange_rate

if doc:
doc.currency = company_currency
doc.posting_date = doc.get("posting_date") or today
doc.transaction_date = doc.get("transaction_date") or today
doc.price_list_currency = price_list_currency
doc.plc_conversion_rate = exchange_rate
doc.conversion_rate = exchange_rate
Expand All @@ -245,9 +249,17 @@ def get_item_detail(item, doc=None, warehouse=None, price_list=None, company=Non
if company:
item["company"] = company

# Create a proper doc structure with company
if not doc and company:
doc = frappe._dict({"doctype": "Sales Invoice", "company": company})
# Create a proper doc structure with company
if not doc and company:
doc = frappe._dict(
{
"doctype": "Sales Invoice",
"company": company,
"currency": item.get("currency"),
"posting_date": today,
"transaction_date": today,
}
)

# Fetch all needed Item fields in a single query (performance optimization)
item_data = (
Expand All @@ -266,6 +278,9 @@ def get_item_detail(item, doc=None, warehouse=None, price_list=None, company=Non
"qty": item.get("qty", 1),
"uom": item.get("uom"), # Include UOM to fetch correct price list rate
"selling_price_list": item.get("selling_price_list"),
"currency": item.get("currency"),
"posting_date": today,
"transaction_date": today,
"price_list_currency": item.get("price_list_currency"),
"plc_conversion_rate": item.get("plc_conversion_rate"),
"conversion_rate": item.get("conversion_rate"),
Expand Down