Skip to content

feat: ignore some directories & files in files achievements#46

Merged
BoxBoxJason merged 4 commits into
mainfrom
fix/ignore-directories
Mar 22, 2026
Merged

feat: ignore some directories & files in files achievements#46
BoxBoxJason merged 4 commits into
mainfrom
fix/ignore-directories

Conversation

@BoxBoxJason
Copy link
Copy Markdown
Owner

This PR adds some default ignore files & directories for the extension achievements.

The user can now configure their achievements.ignore.files and achievements.ignore.directories settings to select paths they want to ignore when progressing their achievements.

Fixes #41

Signed-off-by: BoxBoxJason <contact@boxboxjason.dev>
Signed-off-by: BoxBoxJason <contact@boxboxjason.dev>
Signed-off-by: BoxBoxJason <contact@boxboxjason.dev>
@BoxBoxJason BoxBoxJason self-assigned this Mar 22, 2026
@BoxBoxJason BoxBoxJason added bug Something isn't working code Requires coding skills javascript Pull requests that update javascript code labels Mar 22, 2026
@BoxBoxJason BoxBoxJason requested a review from Copilot March 22, 2026 02:16
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces configurable ignore lists for file-based achievement progression, aimed at preventing events from generated folders and VCS internals (e.g., .git) from triggering achievements (Fixes #41).

Changes:

  • Add new configuration settings for achievements.ignore.files and achievements.ignore.directories (with defaults).
  • Filter file, rename, text-change, and diagnostics listeners to ignore matching paths.
  • Extend the file-listener test suite to validate ignore behavior for common paths (e.g., .git, node_modules, lockfiles).

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/listeners/files.ts Adds default ignore lists and a shouldIgnoreUri gate used by multiple file-related listeners.
src/config/config.ts Extends the config shape with ignore.files / ignore.directories and parses those settings.
src/test/listeners/files.test.ts Adds tests ensuring ignored paths do not trigger progression updates.
package.json Contributes the new settings and their defaults to the extension configuration schema.
README.md Documents the new ignore settings.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/listeners/files.ts
Comment thread src/listeners/files.ts
Comment thread src/listeners/files.ts Outdated
Signed-off-by: BoxBoxJason <contact@boxboxjason.dev>
@BoxBoxJason BoxBoxJason merged commit ea27297 into main Mar 22, 2026
4 checks passed
@BoxBoxJason BoxBoxJason deleted the fix/ignore-directories branch March 22, 2026 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working code Requires coding skills javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Git Edits trigger achievements

2 participants