feat: ignore some directories & files in files achievements#46
Merged
Conversation
Signed-off-by: BoxBoxJason <contact@boxboxjason.dev>
Signed-off-by: BoxBoxJason <contact@boxboxjason.dev>
Signed-off-by: BoxBoxJason <contact@boxboxjason.dev>
There was a problem hiding this comment.
Pull request overview
This PR introduces configurable ignore lists for file-based achievement progression, aimed at preventing events from generated folders and VCS internals (e.g., .git) from triggering achievements (Fixes #41).
Changes:
- Add new configuration settings for
achievements.ignore.filesandachievements.ignore.directories(with defaults). - Filter file, rename, text-change, and diagnostics listeners to ignore matching paths.
- Extend the file-listener test suite to validate ignore behavior for common paths (e.g.,
.git,node_modules, lockfiles).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/listeners/files.ts | Adds default ignore lists and a shouldIgnoreUri gate used by multiple file-related listeners. |
| src/config/config.ts | Extends the config shape with ignore.files / ignore.directories and parses those settings. |
| src/test/listeners/files.test.ts | Adds tests ensuring ignored paths do not trigger progression updates. |
| package.json | Contributes the new settings and their defaults to the extension configuration schema. |
| README.md | Documents the new ignore settings. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: BoxBoxJason <contact@boxboxjason.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds some default ignore files & directories for the extension achievements.
The user can now configure their
achievements.ignore.filesandachievements.ignore.directoriessettings to select paths they want to ignore when progressing their achievements.Fixes #41