fix use-after-free in loadAsNative - #29
Open
180watt wants to merge 1 commit into
Open
Conversation
Owner
|
Thanks for the PR! I wonder why this happens on BSD and not Linux or Windows 🤔 |
Author
|
Most likely an implementation difference between GNU and FreeBSD's ld-elf. I didn't see that there was different branch, I would of just built that. Sorry for the noise with the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a use-after-free in
loadAsNativethat crashes the program on FreeBSD 15.1.This is just a matter of the unique_ptr calling the destructor at the end of
loadAsNative's scope and there still being references to it later in the code. My debugging skills are not great, so I don't see exactly where it's going wrong, just that it is.Perhaps not the most elegant fix (I mainly do C), there will be no hard feelings if you need to clean it up.
Here is the ASAN report that tipped me off to the nature of the bug.
ASAN-Report.txt
--
Best,
180watt