docs: add adversarial review skill guidance#8
Open
Boulea7 wants to merge 2 commits into
Open
Conversation
Change-Id: I66b1c6587edaf35b830c898f755b0dee755d69c3
Reviewer's GuideDocuments a new adversarial review prompt profile for Claude and Codex Antigravity collaboration skills, aligns Antigravity’s collaboration guidance with that profile, and fixes Codex forwarder copy to be Codex-specific with a regression test. Sequence diagram for adversarial review prompt profile in review modesequenceDiagram
actor Reviewer
participant ClaudeSkill
participant AntigravityCollab
Reviewer->>ClaudeSkill: agy path mode=review
ClaudeSkill->>AntigravityCollab: review prompt with adversarial profile
AntigravityCollab-->>ClaudeSkill: findings P0/P1/P2/P3
ClaudeSkill-->>Reviewer: findings and residual risks
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The adversarial review prompt text is duplicated across multiple SKILL and prompt-pattern files; consider introducing a single shared source or generation step for this wording so future edits don’t silently diverge between Claude/Codex and skill-body copies.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The adversarial review prompt text is duplicated across multiple SKILL and prompt-pattern files; consider introducing a single shared source or generation step for this wording so future edits don’t silently diverge between Claude/Codex and skill-body copies.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
Warning Review limit reached
More reviews will be available in 36 minutes and 37 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (13)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR expands the skill documentation to include an “adversarial review” prompt profile (as a stricter mode="review" prompt, not a new mode), updates Antigravity collaboration guidance to explicitly handle adversarial-review requests, and fixes Codex forwarder copy that incorrectly referenced Claude (with a regression test to prevent recurrence).
Changes:
- Add “adversarial review variant” prompt scaffolding to Claude/Codex prompt-pattern references and cross-link it from SKILL docs.
- Update Antigravity collaboration playbooks to instruct stricter checks when the caller requests adversarial review.
- Fix Codex bridge forwarder docstrings to be Codex-specific and add a regression test.
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/test_skill_bridge_forwarders.py | Adds regression test to ensure Codex packaged forwarder copy is Codex-specific. |
| src/agy_mcp/_skill_bodies/codex/SKILL.md | Documents when/how to use the adversarial review prompt profile for Codex. |
| src/agy_mcp/_skill_bodies/codex/scripts/agy_bridge.py | Fixes docstring wording to refer to Codex skill/agent (not Claude). |
| src/agy_mcp/_skill_bodies/codex/references/prompt-patterns.md | Adds “adversarial review variant” prompt scaffold. |
| src/agy_mcp/_skill_bodies/claude/SKILL.md | Documents when/how to use the adversarial review prompt profile for Claude. |
| src/agy_mcp/_skill_bodies/claude/references/prompt-patterns.md | Adds “adversarial review variant” prompt scaffold. |
| src/agy_mcp/_skill_bodies/antigravity/SKILL.md | Updates review guidance to explicitly handle adversarial-review prompts. |
| skills/codex/collaborating-with-antigravity/SKILL.md | Mirrors packaged Codex SKILL docs with adversarial review guidance. |
| skills/codex/collaborating-with-antigravity/scripts/agy_bridge.py | Mirrors packaged Codex forwarder docstring fix. |
| skills/codex/collaborating-with-antigravity/references/prompt-patterns.md | Mirrors packaged Codex prompt-patterns adversarial review variant. |
| skills/claude/collaborating-with-antigravity/SKILL.md | Mirrors packaged Claude SKILL docs with adversarial review guidance. |
| skills/claude/collaborating-with-antigravity/references/prompt-patterns.md | Mirrors packaged Claude prompt-patterns adversarial review variant. |
| skills/antigravity/agy-collaboration/SKILL.md | Mirrors packaged Antigravity collaboration guidance update. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+93
to
+96
| assert "Codex skill" in raw | ||
| assert "Codex agent" in raw | ||
| assert "Claude skill" not in raw | ||
| assert "Claude agent" not in raw |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Change-Id: Ie9fb5e3feaa1ebca509a18082a6a23fd99c2c63c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Reference: derived from gemini-plugin-cc and codex-plugin-cc adversarial-review workflows while keeping agy-mcp's public mode enum unchanged.
Summary by Sourcery
Document an adversarial review prompt profile for Claude and Codex review modes and align Antigravity collaboration behavior and Codex forwarder copy with this profile.
Enhancements:
Documentation:
Tests:
Summary by cubic
Add an adversarial review prompt profile and guidance across Claude/Codex and Antigravity collaboration skills to make high‑risk code reviews stricter. Also fix Codex forwarder wording and tighten the regression test.
New Features
references/prompt-patterns.mdfor Claude and Codex; use withagy(..., mode="review")as a stricter prompt (not a new mode).Bug Fixes
agy_bridge.pyforwarder copy to stop mentioning Claude.test_codex_forwarder_uses_codex_specific_copyto lock Codex-specific wording.Written for commit 7118391. Summary will update on new commits. Review in cubic