fix(ai-chat): emphasize pending Netclaw approvals - #69
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #66
Summary
Pending Netclaw approvals could blend into the activity transcript, particularly in dark mode, and look like a stalled assistant. This PR makes an unanswered approval unmistakable while preserving the existing approval flow.
Implementation
Approval requiredstatus in the activity heading and approval block.data-testid="ai-assistant-approval".denyis an outlined Error action. Unknown future keys remain visible Primary actions.Approval, API, and Netclaw semantics are unchanged: selected
CallIdand option key dispatch, busy disabling, and resolved-approval behavior remain in place.Validation
dotnet build src/HelpDesk.NewWeb/HelpDesk.NewWeb.csproj --configuration Release— passed.HELPDESK_AI_ASSISTANT_CONFIGURATION=Release npm run test:ux:ai-assistant— passed, 14/14 (light/dark desktop/mobile approval presentation and no-horizontal-overflow coverage included).tools/ci/check-public-disclosure.sh— passed.Changed areas
src/HelpDesk.NewWeb/Components/Shared/AiAssistantTurnActivity.razorsrc/HelpDesk.NewWeb/Components/Shared/AiAssistantTurnActivity.razor.csstests/ux/ai-assistant-chat.spec.tstests/ux/ai-assistant-fixture-api.mjstests/ux/auth.tsplaywright.ai-assistant.config.ts.github/workflows/pull-request-validation.ymlCommits:
638c17294bb2deb54476cdbed13b824dd836e92c(fix(ai-chat): emphasize pending approvals (#66))329cda10a3bbad302dfe641b9aa36938e0b78b2c(test(ai-chat): gate approval presentation coverage)No migration, release, tag, deployment, or backend protocol change is included.