Adds accept prop#18
Open
shankie-codes wants to merge 2 commits into
Open
Conversation
Author
|
Great thanks. Let me know when you've released a new version! |
|
I am not the maintainer, so, unfortunately, I can't release a new version. My bad. |
Author
|
Oh. Fair enough!
…On Mon, 25 Nov 2019 at 11:23, Paolo Di Bello ***@***.***> wrote:
I am not the maintainer, so, unfortunately, I can't release a new version.
My bad.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#18?email_source=notifications&email_token=AAT45XUISFVKINFKHH53QPDQVOYTLA5CNFSM4G4J4VZ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFCB4XY#issuecomment-558112351>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAT45XSI7LD7Q2YBXE743HDQVOYTLANCNFSM4G4J4VZQ>
.
--
Andrew Shankie
+44 (0)7843616844
Proper Design
1 Fox Lane, Cardiff, CF24 1JN
+44 (0) 292000 4234
|
|
Would you mind reviewing my pull requests too? It looks almost like yours but I added disabled instead. |
|
The props could be pass directly like this: |
Author
|
Looks the same as my stuff @PaoloDiBello – just passing additional props to the underlying component. @BosNaufal can we get these little tweaks merged? |
|
Why not, do you know how? |
Author
|
No, I'm not sure I'm sorry |
|
Such a prop would be very useful. @BosNaufal is it planned to merge the changes? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I need to be able to control which file types the component accepts. I've added a passed-through
acceptprop.