Rename project_eigenvectors to rotate_to_physical_auxiliary_basis with improved documentation#19
Closed
Copilot wants to merge 2 commits intofix_dyson_combinationfrom
Closed
Rename project_eigenvectors to rotate_to_physical_auxiliary_basis with improved documentation#19Copilot wants to merge 2 commits intofix_dyson_combinationfrom
project_eigenvectors to rotate_to_physical_auxiliary_basis with improved documentation#19Copilot wants to merge 2 commits intofix_dyson_combinationfrom
Conversation
Merged
…h improved docstring Co-authored-by: obackhouse <34662120+obackhouse@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix function naming and documentation for Spectral
Rename Dec 17, 2025
project_eigenvectors to rotate_to_physical_auxiliary_basis with improved documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renamed
project_eigenvectorsindyson/util/linalg.pyto better reflect its purpose: constructing a biorthonormal basis spanning physical (Dyson orbitals) and auxiliary (null space) spaces, then rotating eigenvectors into that basis.Changes
Function rename:
project_eigenvectors→rotate_to_physical_auxiliary_basisrotate_subspace,set_subspace)Enhanced docstring:
Updated call sites:
spectral.py,exact.py,davidson.py,util/__init__.pyExample
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.