Skip to content

Comment mentions #5944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ssddanbrown wants to merge 8 commits into
base: development
Choose a base branch
from
Open

Comment mentions #5944

ssddanbrown wants to merge 8 commits into from
+1,067 −117

Conversation

@ssddanbrown
Copy link
Member

@ssddanbrown ssddanbrown commented Dec 8, 2025 •
edited
Loading

Related to #560.

Todo

  • Finish off editor UI.
  • Address remaining todos in code changes
  • Add lookup for users
    • Limit to those with ability to create/update comments for now.
  • Back-end comment parsing
  • Notification on mention
  • Notification preferences - Add option for comment mentions.
  • Test cases for back-end functionality.
    • Add test to cover new user search endpoint.
  • Stress-test & fix editor/front-end behaviour
    • Mention strips out text after mention within same text block.
  • Dark mode test
  • Chromium test

Considerations

  • How do we handle mention changes on comment updates.
    • We're tracking mentions via the database, and only mention if a new mention is added, so we don't notify for prior mentions (even if a notification was not sent before).
  • Do we need rate limiting to prevent spam like page update notifications.
    • Avoid for now, but should be able to track/add via history system if found to be needed upon user feedback.
  • Are these useful if we don't opt-in users to them by default?
    • We will opt in those with notification permissions by default. Add extra further consideration for admin-level user notification management in future.

Doc Updates

  • Update advisory - Anyone with comment create/update will technically be able to access a list of system users.
  • Update advisory - Any users with a "Receive & manage notifications" role permission will be opted-in to comment mention notifications by default.

@ssddanbrown ssddanbrown self-assigned this Dec 8, 2025
@ssddanbrown
Mentions: Added new endpoint, Built editor list display
9bf9ae9
@ssddanbrown
Lexical: Changed mention to be a decorator node
1e768ce 
Allows better selection.
Also updated existing decorator file names to align with classes so
they're easier to find.
Also aligned/fixed decorator constuctor/setup methods.
@ssddanbrown
JS: Swapped livereload lib for esbuild livereload setup
147ff00
@ssddanbrown
Comment Mentions: Added keyboard nav, worked on design
e2f91c2
@ssddanbrown
Comment Mentions: Added core back-end logic
221c6c7 
- Added new user notification preference, opt-in by default
- Added parser to extract mentions from comment HTML, with tests to
  cover.
- Added notification and notification handling

Not yet tested, needs testing coverage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ssddanbrown ssddanbrown

Labels

💻 Front-End 🏭 Back-End 🛠️ Enhancement

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ssddanbrown