Repository navigation
Emoji font: review follow-up from longbridge/gpui-mobile#29 - #10
Closed
Bombatomica64 wants to merge 1 commit into
Closed
Bombatomica64 wants to merge 1 commit into
Bombatomica64 wants to merge 1 commit into
Conversation
Review follow-up for the host-path emoji font: - If host::start runs before set_host_activity, the platform finds no AssetManager. It now leaves its text system pending and logs a warning, and set_host_activity loads the font once it has the AssetManager. The host.rs docs say set_host_activity comes first. - host_assets runs in a JNI local frame, so the context and AssetManager local references are freed even when the caller stays in native code. - set_host_activity clears a pending exception on every error path. - load_asset_bytes reads the asset into one Vec of its size instead of copying the mapped buffer, so the ~10 MB font is not held twice. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Owner
Author
|
Conflicts with main's jni refactor; replaced by a branch with the merge resolved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the review follow-up for longbridge#29 (773e5ad) into the lab's pinned main: deferred emoji font load when `host::start` comes first, JNI local frame in `host_assets`, exceptions cleared on every `set_host_activity` error path, single-buffer asset read.
🤖 Generated with Claude Code