Repository navigation
Plan A4: patch deltas, fewer adb round trips, USB timings; bump gpui-hot - #74
Merged
Merged
Conversation
gpui-hot moves to cargo-gpui 266146c (cargo-gpui#2), which sends patches as deltas against the previous patch and does patches and reloads in one adb call each. A4 records the numbers through the tunnel and over USB. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gpui-hotto cargo-gpui266146c(cargo-gpui#2, merged). That change sends patches as zstd deltas against the previous patch, and does each patch and each delta reload in one adb call.gpui-hotitself is unchanged; the rev keeps the lab in step with the CLI. Only the twogpui-hotsource lines change inCargo.lock.docs/hot-patching-plan.md: a new A4 section, and A1's status now points to it.Measured on the phone (OnePlus, Android 16; Buttons screen, one-line change):
-3deltas (0.32 MB). The final-9(0.10 MB) ran through the tunnel only while another job saturated the server, so its timings are noted in A4 as skewed, not tabled.aslr. The end-to-end USB figure (~2.2 s per patch) is an estimate, as A4 says.🤖 Generated with Claude Code