Repository navigation
Keep GpuiLibraryLoader in the lab's Java sources - #72
Merged
Merged
Conversation
LabActivity references it at compile time, but only build.sh generated it, so `cargo gpui apk` on a clean checkout failed to compile (Codex review on #70). The lab keeps a copy next to GpuiClipboard.java, as for the other helpers it calls from Java, and build.sh no longer copies it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Codex's P1 on #70.
LabActivityreferencesGpuiLibraryLoaderat compile time, but onlybuild.shgenerated the class. Socargo gpui apk, which runs Gradle withoutbuild.sh, failed to compile on a clean checkout. It worked locally only because an earlierbuild.shrun had leftandroid/app/build/generatedbehind.The lab now keeps a copy in
android/app/src/main/java/dev/gpui/mobile/, next toGpuiClipboard.java. It's byte-identical to gpui-mobiledev-hot-loader, andbuild.shno longer copies it, which would duplicate the class. The two docs that mentioned the copy are updated.Verified: with
android/app/builddeleted,cargo gpui apkbuilds the APK.🤖 Generated with Claude Code