Store ActorNotFound failures when store_results is set - #887
Open
DSeaStar wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #448.
When a worker receives a message for an actor that is not imported locally,
Results._lookup_options()treatedstore_resultsas false.after_nackthen skipped the result backend, somessage.get_result()waited until timeout instead of raisingActorNotFound.The producer already knows the actor's options.
before_enqueuenow copiesstore_results/result_ttlonto the message, and_lookup_optionsfalls back to those (then the middleware defaults) when the actor is missing. A worker that never imported the actor can still persist the failure.Messages that never asked for results are unchanged:
after_nackstill no-ops whenstore_resultsis unset.