Add feature for firing group completion callbacks on failure - #868
Open
MyrikLD wants to merge 1 commit into
Open
Add feature for firing group completion callbacks on failure#868MyrikLD wants to merge 1 commit into
MyrikLD wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add_completion_callbacknever fires if any task in the group fails permanently — the barrier just hangs forever. But a permanent failure is a completion; the group is done, just not successfully. The current behaviour is closer toadd_success_callback.Proposed fix: add
fire_on_failure=FalsetoGroupCallbacks. WhenTrue, the barrier is decremented on permanent failure (message.failed) and on skipped messages, firing the callbacks regardless of outcome. Defaults toFalsefor backwards compatibility.Prior art:
dramatiq-workflowworks around this externally viamessage.failed— the need is real.Happy to submit a PR if this direction sounds good.