fix(validator): remove go-just nested module#494
Draft
kehoecj wants to merge 1 commit into
Draft
Conversation
…ency resolution The justfile parser was a separate Go module (github.com/Boeing/go-just) embedded via a replace directive. Since replace directives don't propagate to consumers, any external project importing config-file-validator failed on 'go mod tidy' trying to fetch the unpublished module. Fix by converting pkg/validator/justfile from a nested module into a regular package within the main module. Rename the package from 'gojust' to 'justfile' to match the directory name. - Delete pkg/validator/justfile/go.mod - Remove replace directive and go-just require from root go.mod - Rename package gojust -> justfile in all source files - Update import path in pkg/validator/justfile.go - Remove separate CI steps for the nested module - Add nolint annotations for false positives previously suppressed by the nested .golangci.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The justfile parser was a separate Go module (github.com/Boeing/go-just) embedded via a replace directive. Since replace directives don't propagate to consumers, any external project importing config-file-validator failed on 'go mod tidy' trying to fetch the unpublished module.
Fix by converting pkg/validator/justfile from a nested module into a regular package within the main module. Rename the package from 'gojust' to 'justfile' to match the directory name.