Improve #467 implementation #468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the XShmGetImage backend, there was a window of time during which a KeyboardInterrupt (or other asynchronous exception) would cause cleanup of the MSS object to raise a different exception. This is one of the slower parts of this backend, so it's a time when asynchronous exceptions can hit pretty easily. While a Python library almost never can guarantee correctness following an asynchronous exception, ending a program with Ctrl-C is not uncommon. We can't guarantee correctness in all circumstances, and shouldn't try to. All this patch does is to avoid the exception that may be hard for an end user to understand. Instead, the top-level user code will now see the KeyboardInterrupt, and not the seemingly-unrelated cleanup exception.
I just learned that memoryviews can be used as context managers, and release their buffers at the end of that, instead of having to be GC'd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the same time as @BoboTiG merged #467, I realized there's a better implementation. Passes pytest and check.sh.