Skip to content

feat: added sort feature to sort musics in the mediastore page#41

Open
Elnix90 wants to merge 1 commit into
BobbyESP:masterfrom
Elnix90:master
Open

feat: added sort feature to sort musics in the mediastore page#41
Elnix90 wants to merge 1 commit into
BobbyESP:masterfrom
Elnix90:master

Conversation

@Elnix90
Copy link
Copy Markdown

@Elnix90 Elnix90 commented May 2, 2026

No description provided.

@BobbyESP
Copy link
Copy Markdown
Owner

BobbyESP commented May 3, 2026

Hi! Thanks for creating the very first Pull Request from a collaborator in Metadator, I really appreciate it.

The code seems really good for me. I'll merge it when I'm free. Right now I'm studying for my finals. Anyways I'm planning a rewrite for this app since the code quality is very poor and does not do well its job.

@Elnix90
Copy link
Copy Markdown
Author

Elnix90 commented May 3, 2026

I noticed that your code base contains lots of boilerplate, especially concerning the settings system, in order to add a settings, I had to edit multiple files and specify at multiple places the default value, etc.
I don't know if this is the most optimized, but for my app, I build a strong and easy settings system. the only problem being that it may not be really optimized and ressources intensive. You may check it out, and copy it or inspire you to rebuild yours!

https://github.com/Elnix90/Dragon-Launcher/blob/e3e809855cc50f918843e75ff20794924011500e/core/settings/src/main/kotlin/org/elnix/dragonlauncher/settings/bases/BaseSettingStore.kt

@BobbyESP
Copy link
Copy Markdown
Owner

BobbyESP commented May 3, 2026

Thanks for the suggestions, mate. The settings have always tripped me up a bit, not gonna lie. I was experimenting with a way to listen for changes in the settings, but the system used in Metadator definitely isn’t great hahah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants