Skip to content

fix: capture Codex Plan Review transcripts - #8

Merged
BobDLA merged 1 commit into
mainfrom
fix/codex-plan-review-cache
Aug 11, 2026
Merged

fix: capture Codex Plan Review transcripts#8
BobDLA merged 1 commit into
mainfrom
fix/codex-plan-review-cache

Conversation

@BobDLA

@BobDLA BobDLA commented Aug 11, 2026

Copy link
Copy Markdown
Owner

Summary

  • capture Codex replies from both notify argv and Stop-hook stdin without logging payload content
  • recover Plan Review content from the exact same-session, same-turn transcript item_completed/Plan event when Codex sends null assistant-message fields
  • keep PID/session isolation so the current plan replaces an earlier ordinary reply
  • document Hook trust, transcript fallback, and the Codex Plan-dialog Ctrl+G limitation in English and Chinese
  • add unit, binary integration, UI, OpenSpec, and named regression coverage

Validation

Ran

  • pnpm lint
  • pnpm typecheck
  • pnpm test — 102 tests passed
  • pnpm test:docs
  • cargo test --manifest-path src-tauri/Cargo.toml — 66 unit tests and 15 integration tests passed
  • openspec validate --all — 6 specs passed
  • pnpm tauri:build — Linux deb built successfully
  • installed the generated cliv_0.2.4_amd64.deb locally and replayed the reported real Codex transcript through /usr/bin/cliv; the Plan replaced the stale ordinary reply
  • manual Codex Plan flow confirmed on the installed build

Not run locally

  • pnpm test:e2e
    • reason: GitHub PR CI runs the browser suite; the changed behavior is covered by Rust process/cache integration tests
  • pnpm test:e2e:desktop:unix
    • reason: GitHub PR CI runs desktop smoke; the installed package was validated directly against a real Codex Plan transcript

@BobDLA
BobDLA merged commit 2457502 into main Aug 11, 2026
2 checks passed
@BobDLA BobDLA mentioned this pull request Aug 11, 2026
@BobDLA
BobDLA deleted the fix/codex-plan-review-cache branch August 11, 2026 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant