Repository navigation
No-Node quickstart via prebuilt ghcr image (compose --profile server) - #6
Conversation
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 552af5dfcb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| depends_on: | ||
| - postgres |
There was a problem hiding this comment.
In the documented docker compose --profile server up -d path, the new server container starts immediately after the Postgres container is created, but apps/server/src/index.ts runs await migrate() before listening and db.ts performs a single pool.connect() with no retry. Docker’s Compose service docs state that short depends_on only controls startup order and “does not wait for dependency services to be ‘healthy’” (https://docs.docker.com/reference/compose-file/services/#depends_on), so on a fresh volume the server can race Postgres initialization, exit on ECONNREFUSED, and leave the advertised no-Node quickstart down. Add a Postgres healthcheck and use condition: service_healthy here, or make the server retry DB connection.
Useful? React with 👍 / 👎.
Co-Authored-By: Claude Fable 5 noreply@anthropic.com