Add icon support to the time app#731
Open
gerritdevriese wants to merge 3 commits intoBlueforcer:mainfrom
Open
Conversation
|
That would be great ! Any news about ? |
Author
|
@Blueforcer I have been running this build for 5 months without any issues, any idea if you will be able to merge this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two new TMODES (7 and 8) making it possible to add icons to the built-in time app as requested in #727
Similar to the "bigtime" mode it checks for a specific file
time.gifin the root directory, if nothing is found it falls back to the clock icon that I found in icons.h: icon_13.The LaMetric TIME also has this feature, called clockfaces: https://faces.lametric.com
8x8 icons work fine, but you can also do some fun things with 8x32 GIFs 🙂
Obviously I cannot modify the mobile app, so for now setting the TMODE to anything higher than 6 can only be done using a POST call to /api/settings