feature(perf): Adding perf and support APP_ID config#57
Open
BlueShork wants to merge 13 commits into
Open
Conversation
Add an App ID setting that maestro-deck forwards to every run as
`-e APP_ID=<value>`, so flow files referencing ${APP_ID} (the CI
placeholder) run locally without per-file edits. Empty value passes
nothing, preserving prior behavior. Threaded through all four runners
(Android, Web, iOS sim, iOS physical).
Add a 'Billy AI' settings section that lets users override Billy's system prompt and reset back to the version shipped with the app. The override is stored as customPrompt|null in a persisted store, so users who never customize keep receiving the latest embedded prompt across updates; getEffectiveBillyPrompt() resolves override ?? embedded and is read fresh on each message.
…title Add persist version:1 + migrate to panelsStore so that upgrading users with metrics:true in localStorage have it forced to false exactly once, honouring the closed-by-default / opening-starts-capture design intent. Export migratePanelsStore for direct unit-test coverage (3 new tests). Update RunConsole toggle title from "Toggle performance HUD" to "Toggle performance panel" to match the visible label.
- Replace deviceConnected with deviceKey (serial:platform:physical) in the metrics capture effect so a direct A→B device switch re-runs the effect, stopping the old collector and clearing stale samples before the new one starts — prevents misattributed data. - Guard run_loop / run_loop_ios_sim self-clear against stop()→start() race: track exit_by_cancel and skip the tokio::spawn self-clear on cancel exits, since stop() already .take()s the RUNNING slot. - Distinguish Ok(None) from Err(e) in ios-sim cpu_mem match: errors now increment consecutive_errors and trigger MAX_CONSECUTIVE_ERRORS bail with emit_stopped, matching the pid-resolution path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
What
Why
Closes #
How
Checklist
feat(inspector): ...)pnpm typecheck && pnpm lintpassescargo fmt --check && cargo clippy -- -D warningspassescargo test --libpassesunwrap()/expect()in production code paths