Require hyprland-config 0.9.14 and hyprland-state 0.4.4 - #77
Open
BlueManCZ wants to merge 1 commit into
Open
Conversation
Both carry the Lua save fix: Document.save() emitted Hyprlang whatever the document was read from, and options read from Lua lost their category prefix on the first edit. hyprmod never hits either path — it writes its managed file through serialize_any() and edits Lua entrypoints as text — so this is floor hygiene, not a fix. hyprland-schema stays at 0.6.3. 0.7.0 bundles the v0.56.1 schema, and hyprland_schema.load() only matches its own "vX.Y.Z" keys, so the bare version hyprland-state reads from hyprctl misses, falls through to a GitHub fetch that 404s, and lands on the bundled latest. Today that accident yields the right schema; under 0.7.0 every 0.55 user would silently get 0.56 options and gradient-typed shadow colors. Signed-off-by: BlueManCZ <ivo97@centrum.cz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Floor bump for the two libraries carrying the Lua save fix (hyprland-config#3, hyprland-state#3). hyprmod never hits either bug — it writes its managed file through
serialize_any()and edits Lua entrypoints as text, never round-tripping a user's.luathrough aDocument— so this is hygiene, not a fix.Nix pins updated to match (
tests/test_nix_pins.pyenforces it). Hashes were computed by reimplementing the NAR hash the fetcher uses, validated by reproducing the three existing pins byte-for-byte before computing the new ones.Not bumped
Why hyprland-schema is held back
hyprland_schema.load()matches its bundled keys, which arevX.Y.Z. hyprland-state passes the bare versionhyprctlreports, so the lookup misses, falls through to a GitHub fetch that 404s, and lands onOPTIONS_BY_KEY— the bundled latest:Under 0.6.3 the fallback happens to be v0.55.4, so the accident is invisible. Under 0.7.0 every user not on 0.56 would silently get 0.56's option set and types, plus a doomed network call at startup. Worth fixing in hyprland-schema (accept both spellings) before this floor moves.