size b2nd shape buffers to B2ND_MAX_DIM in ndmean and ndlz#783
Closed
alhudz wants to merge 1 commit into
Closed
Conversation
Member
|
Already addressed in #781. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro: store a b2nd array whose metalayer declares
ndimin9..16, with thendmeanfilter (or thendlzcodec), then read it back. ASAN reports a heap write past theshape/chunkshape/blockshapebuffers inb2nd_deserialize_meta.Cause:
ndmean_forward/ndmean_backwardandndlz4_compress/ndlz8_compressallocate those buffers with8slots, butb2nd_deserialize_metafills up toB2ND_MAX_DIM(16) entries straight from the metalayer.ndmeanthen indexes itsNDMEAN_MAX_DIMstack arrays with the same uncheckedndim.Fix: size the buffers to
B2ND_MAX_DIM, asndcelland thezfpcodec already do, and rejectndimoutside1..NDMEAN_MAX_DIMinndmeanthe wayndcelldoes.