-
Notifications
You must be signed in to change notification settings - Fork 5
Project file improvements and retarget #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
LumpBloom7
merged 12 commits into
BloomCreativeWorks:master
from
LumpBloom7:Improvements/vcxproj
Aug 16, 2019
Merged
Project file improvements and retarget #32
LumpBloom7
merged 12 commits into
BloomCreativeWorks:master
from
LumpBloom7:Improvements/vcxproj
Aug 16, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before it would complain about Nuget packages not being installed because it wasn't looking for it relative to `$(SolutionDir)`.
Don't have to change TestBench includes and enTT directory because it is more reliable to use the current paths.
It also allows us to use the Windows subsystem without issues.
This will result in a cross-dependent situation where the packages cannot be downloaded without loading the project, but the projects need the packages to be downloaded before being able to load.
We will have to resolve all those issues ahead of C++20 at some point...
I'm such a fucking retard...
Switch from VS2017 to VS2019, small config cleaning
Since I don't want to update it too :) Use Azure Piplines instead
kasmacioma
approved these changes
Aug 16, 2019
Collaborator
kasmacioma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leave a comment (i'm too lazy to write something)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it easier to import these projects as a submodule, requiring no adjustments to make in the BloomFramework project file to get things working.
Also retargeted projects to the latest toolset(v142)